Coder Social home page Coder Social logo

Comments (1)

roymoran avatar roymoran commented on September 28, 2024

@rmjordas looks like we already had an issue for this and it was closed. Although the issue technically wasn't resolved - I've opened it again so we can re-visit it. I took a look at the code and this doesn't necessarily need a refactor for the http client class like I originally said - we just need to make sure we display the error message the api returns if the request fails.

You can reproduce by visiting the test/production environment and submitting the signup form with an existing email. The API returns the Error object. But we have hard coded the UI to display a different message which becomes confusing like someone pointed out in #general.

Here's the UI and message we display
Screen Shot 2020-02-11 at 5 12 19 PM

Here's the message we should display. It isn't any better but that's an issue I can resolve on the backend.
Screen Shot 2020-02-11 at 4 52 23 PM

If you can resolve this one - we will use it as a pattern to display api error messages for other api requests we make.

from pub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.