Comments (4)
Yeah sounds reasonable, can you create an issue for this as well so that we don't forget the main aim if this issue.
If you want to work on this issue, you can break this issue into parts as this is one of the epic issue that require many files to get changed
Assigning this issue to you
from mirai.
Yeah Removed
from mirai.
I am willing to take up this issue.
I have another suggestion regarding the code modularity. Currently the controller functions for each of the routes are written right inside the route definition. Example:
router.get("/", function (req, res, next) {
request(
"https://www.gogoanime1.com/search/topSearch?q=" + req.query.q,
(error, response, html) => {
res.send(response.body);
}
);
});
A good convention to follow is to create a controllers/ directory and have all these controller functions (let's call the above handler function as topSearchHandler) in there so that the api end point just has to call the function:
router.get("/", topSearchHandler)
from mirai.
Thank you. I'll do that.
Also, there a typo in the issue label refractor
should be refactor
I guess. 😅
from mirai.
Related Issues (20)
- Ongoing anime always empty HOT 1
- Video streaming error HOT 1
- Anime list oddly aligned HOT 3
- adding contributors profile image with Github handle in readme HOT 1
- Improve UI of the search bar HOT 5
- api help HOT 1
- While scrolling down the image does not remain steady HOT 1
- Dividing the Anime list Pages HOT 1
- Adding genre to the anime list. HOT 6
- Card view for latest Manga HOT 4
- Update README file HOT 2
- To add contributor's name in README.md file HOT 1
- add contributing.md HOT 1
- Designing a perfect Anime Landing page for Mirai Website HOT 3
- card view for anime list page
- Redesign navbar and add footer HOT 1
- Add responsiveness and fix bugs HOT 1
- Creating React App for the project HOT 1
- End point controllers refactoring HOT 3
- Scraping Content from LightNovel HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mirai.