Coder Social home page Coder Social logo

Modular code needed about mirai HOT 4 OPEN

projectsakura avatar projectsakura commented on June 13, 2024
Modular code needed

from mirai.

Comments (4)

ArunTeltia avatar ArunTeltia commented on June 13, 2024 1

Yeah sounds reasonable, can you create an issue for this as well so that we don't forget the main aim if this issue.
If you want to work on this issue, you can break this issue into parts as this is one of the epic issue that require many files to get changed
Assigning this issue to you

from mirai.

ArunTeltia avatar ArunTeltia commented on June 13, 2024 1

Yeah Removed

from mirai.

singhayushh avatar singhayushh commented on June 13, 2024

I am willing to take up this issue.

I have another suggestion regarding the code modularity. Currently the controller functions for each of the routes are written right inside the route definition. Example:

router.get("/", function (req, res, next) {
  request(
    "https://www.gogoanime1.com/search/topSearch?q=" + req.query.q,
    (error, response, html) => {
      res.send(response.body);
    }
  );
});

A good convention to follow is to create a controllers/ directory and have all these controller functions (let's call the above handler function as topSearchHandler) in there so that the api end point just has to call the function:

router.get("/", topSearchHandler)

from mirai.

singhayushh avatar singhayushh commented on June 13, 2024

Thank you. I'll do that.

Also, there a typo in the issue label refractor should be refactor I guess. 😅

from mirai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.