Comments (6)
Bumping this!
from seaport-js.
thanks for the report, if you were interested in opening a PR to add the suggested test and fix, it would be much appreciated! otherwise we can try to address soon
from seaport-js.
Will let you know if I or my team gets some bandwidth to help out here. Currently we're quite busy but I'll revisit this later.
from seaport-js.
thanks again for the detailed report, i'll work on a PR to fix
from seaport-js.
Hey @bam4564, here is my PR: #490 if you don't mind taking a look and see if it fixes the issue.
I added tests to partial fill twice to recreate the unitsToFill issue, with 50 then 7 units out of 100 as your example showed.
from seaport-js.
@ryanio thanks so much for the work here. A little busy this week with work launching a few things that require stability in our systems. Will pass this off to our frontend team and they can experiment with this new version so see if it solves our issues. Should be able to test sometime this upcoming week!
from seaport-js.
Related Issues (20)
- getOrderHash gives another hash then smart contract HOT 2
- Seaport Doc HOT 3
- husky: command not found HOT 6
- Fail to Create a listing, not a clear error HOT 4
- Information - Upgrade / Migration from Seaport 1.1 to Seaport 1.5 HOT 2
- Issue creating a listing. HOT 10
- English auction orders not fillable by OpenSea HOT 5
- Is there anyway to use this seaport-js to interact with Seaport 1.1 contracts? HOT 1
- seaport-js v3 planning HOT 1
- Signing with contract wallet may generate signatures longer than 64/65 bytes HOT 2
- End price is not working HOT 1
- Improperly Controlled Modification of Object PrototypePollution leads to module code execution HOT 2
- Creating a collection offer returns error HOT 5
- 「SecurityError: The operation is insecure」 when executing createOrder on mobile. HOT 1
- There is a security concern with "[email protected]". It needs to be updated to "[email protected]". HOT 1
- Is this a way to use opensea pro with seaport-js HOT 1
- Inaccurate Tip Adjustment in Partial Fill Scenarios in Seaport SDK HOT 3
- seaport-js v5 planning
- Add transaction overrides to all functions that send txs. HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from seaport-js.