Coder Social home page Coder Social logo

Comments (6)

bam4564 avatar bam4564 commented on June 30, 2024

Bumping this!

from seaport-js.

ryanio avatar ryanio commented on June 30, 2024

thanks for the report, if you were interested in opening a PR to add the suggested test and fix, it would be much appreciated! otherwise we can try to address soon

from seaport-js.

bam4564 avatar bam4564 commented on June 30, 2024

Will let you know if I or my team gets some bandwidth to help out here. Currently we're quite busy but I'll revisit this later.

from seaport-js.

ryanio avatar ryanio commented on June 30, 2024

thanks again for the detailed report, i'll work on a PR to fix

from seaport-js.

ryanio avatar ryanio commented on June 30, 2024

Hey @bam4564, here is my PR: #490 if you don't mind taking a look and see if it fixes the issue.

I added tests to partial fill twice to recreate the unitsToFill issue, with 50 then 7 units out of 100 as your example showed.

from seaport-js.

bam4564 avatar bam4564 commented on June 30, 2024

@ryanio thanks so much for the work here. A little busy this week with work launching a few things that require stability in our systems. Will pass this off to our frontend team and they can experiment with this new version so see if it solves our issues. Should be able to test sometime this upcoming week!

from seaport-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.