passing a custom publicPath breaks serialization about greenwood

[hutchgrant]

I don't think it ever supported custom publicPaths other than the default '/'. Though consideration was made for it within our 404 and index templates. But now that it's consolidated and available under the config, this feature is needed.

[thescientist13]

but it's there in config.js?
https://github.com/ProjectEvergreen/greenwood/blob/master/packages/cli/lib/config.js#L31

[thescientist13]

will look at as I / after working on #66 , which now makes the case easy to reproduce. Just compare having a custom greenwood.config.js

// bueno
module.exports = {};

// no bueno
module.exports = {
  publicPath: '/owen'
}

and running

$ yarn build
$ cat ./public/index.html

and compare the output

[thescientist13]

This seems to be the offending publicPath, in webpack.config.common.js
https://github.com/ProjectEvergreen/greenwood/blob/master/packages/cli/config/webpack.config.common.js#L42

output: {
  path: context.publicDir,
  filename: '[name].[hash].bundle.js',
  publicPath: '/' // config.publicPath
},

will serialize even when publicPath is set in greenwood.config.js

It seem the webpack output is the same in .greenwood/, so seems to be isolated to just the serialize part of the pipeline.

[thescientist13]

Ok, seems to be related to the interplay between setting output.path and output.publicPath, think I might have a handle on it

[hutchgrant]

Did this get resolved yet? I don't see a PR for this issue.

[thescientist13]

Still open. Was hoping getting #74 in first would help with debugging