safeSplit will discard quoted single word (w/o space) about core

[jschwinger233]

其实我觉得让 grpc 接口里的 command 字段改为 []string 才是最好的, 完全不会出现任何歧义, 这是和 exec(2) 参数完全对应的.

如果保持现有的 string 类型手动切, 恐怕还要考虑 echo "a \"b" 这种引号中有转义引号的情况, 上面那段代码简单改改是不行的. 不如容我写一段没人能看懂的正则表达式.....

[CMGS]

just do it

…

On Wed, Nov 11, 2020 at 10:25 PM zc ***@***.***> wrote: 其实我觉得让 grpc 接口里的 command 字段改为 []string 才是最好的, 完全不会出现任何歧义, 这是和 exec(2) 参数完全对应的. 如果保持现有的 string 类型手动切, 恐怕还要考虑 echo "a \"b" 这种引号中有转义引号的情况, 上面那段代码简单改改是不行的. 不如容我写一段没人能看懂的正则表达式..... — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#262 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD3S2CUL7T3L2NSU3GEFRLSPKNGVANCNFSM4TQNISZA> .

--

-CMGS A simple coder. Love travel, sports especially outdoor sports and computer technology. Have a dream that one day can tour around.

[jschwinger233]

不过正则表达式也写出来了, 是这样的: [^'"\s]\S*|'(?:\\.|[^'])*'|"(?:\\.|[^"])*"

In [26]: re.findall(r'''[^'"\s]\S*|'(?:\\.|[^'])*'|"(?:\\.|[^"])*"''', r'''echo 'asdf asdf' 'ads' 'a\'a' "adsf" "12 1"
    ...:  "as \" sdf"''')
Out[26]: ['echo', "'asdf asdf'", "'ads'", "'a\\'a'", '"adsf"', '"12 1"', '"as \\" sdf"']

[CMGS]

hmm 那就 open issue 苟着吧

…

On Wed, Nov 11, 2020 at 11:14 PM zc ***@***.***> wrote: 不过正则表达式也写出来了, 是这样的: [^'"\s]\S*|'(?:\\.|[^'])*'|"(?:\\.|[^"])*" In [26]: re.findall(r'''[^'"\s]\S*|'(?:\\.|[^'])*'|"(?:\\.|[^"])*"''', r'''echo 'asdf asdf' 'ads' 'a\'a' "adsf" "12 1" ...: "as \" sdf"''') Out[26]: ['echo', "'asdf asdf'", "'ads'", "'a\\'a'", '"adsf"', '"12 1"', '"as \\" sdf"'] — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#262 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAD3S2ETFM7NUM7LNXL7TBLSPKS2VANCNFSM4TQNISZA> .

--

-CMGS A simple coder. Love travel, sports especially outdoor sports and computer technology. Have a dream that one day can tour around.

[CMGS]

fixed in #267

[warriorguo]

我也遇到类似问题，传入command无法正常读出参数。
core版本是v21.03.15
cli版本是v21.03.01
执行lambda输出

$eru-cli lambda --pod proxy --name test --file ./testab:/bin/testab "/bin/testab -a 'show me the money' -b 'operation'"
[cfdb5d301b8066956f7e546c723532796b7af1ec735fd1658e0b2fc04241d3f8] flag needs an argument: -b
[cfdb5d301b8066956f7e546c723532796b7af1ec735fd1658e0b2fc04241d3f8] Usage of /bin/testab:
[cfdb5d301b8066956f7e546c723532796b7af1ec735fd1658e0b2fc04241d3f8]   -a string
[cfdb5d301b8066956f7e546c723532796b7af1ec735fd1658e0b2fc04241d3f8]
[cfdb5d301b8066956f7e546c723532796b7af1ec735fd1658e0b2fc04241d3f8]   -b string
[cfdb5d301b8066956f7e546c723532796b7af1ec735fd1658e0b2fc04241d3f8]

直接执行binary

$./testab -a 'show me the money' -b 'operation'
a=show me the money,b=operation

testab的代码如下

package main

import (
	"flag"
	"fmt"
)

func main() {
	var (
		a, b string
	)
	flag.StringVar(&a, "a", "", "")
	flag.StringVar(&b, "b", "", "")
	flag.Parse()

	fmt.Printf("a=%s,b=%s\n", a, b)
}

[chrisxuwq]

我也遇到类似问题，传入command无法正常读出参数。
core版本是v21.03.15
cli版本是v21.03.01
执行lambda输出

$eru-cli lambda --pod proxy --name test --file ./testab:/bin/testab "/bin/testab -a 'show me the money' -b 'operation'"
[cfdb5d301b8066956f7e546c723532796b7af1ec735fd1658e0b2fc04241d3f8] flag needs an argument: -b
[cfdb5d301b8066956f7e546c723532796b7af1ec735fd1658e0b2fc04241d3f8] Usage of /bin/testab:
[cfdb5d301b8066956f7e546c723532796b7af1ec735fd1658e0b2fc04241d3f8]   -a string
[cfdb5d301b8066956f7e546c723532796b7af1ec735fd1658e0b2fc04241d3f8]
[cfdb5d301b8066956f7e546c723532796b7af1ec735fd1658e0b2fc04241d3f8]   -b string
[cfdb5d301b8066956f7e546c723532796b7af1ec735fd1658e0b2fc04241d3f8]

直接执行binary

$./testab -a 'show me the money' -b 'operation'
a=show me the money,b=operation

testab的代码如下

package main

import (
	"flag"
	"fmt"
)

func main() {
	var (
		a, b string
	)
	flag.StringVar(&a, "a", "", "")
	flag.StringVar(&b, "b", "", "")
	flag.Parse()

	fmt.Printf("a=%s,b=%s\n", a, b)
}

我现在是对single word的input用strconv.Quote()来avoid的

[chrisxuwq]

刚刚竟然发现了个bug少点的func https://github.com/google/shlex/blob/master/shlex.go

[jschwinger233]

tql

…

On Fri, 16 Jul 2021 at 10:01 PM, chrisxuwq ***@***.***> wrote: 刚刚竟然发现了个bug少点的func https://github.com/google/shlex/blob/master/shlex.go — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#262 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRDGKFWICQVIELVIR64U5DTYA3SRANCNFSM4TQNISZA> .