Audio glitches on 2.0 BETA about proffieos

[profezzorn]

If I was a betting man (which I am not), I would suspect that these problems stem from:

fc0ab5f and
e02043e

(Those two were really meant to be one commit.)

They are meant to fix another problem where wav players can have Stop() called from an interrupt which can cause a lot of problems.

[SA-22C]

That's a good place to start. Thanks.

https://youtu.be/w8j_dFemSgQ

[SA-22C]

I'm getting glitches all the way back to the commit flagged in my original issue. Using code after 918aeab produces the bug. I'll try to use bisect to figure out the cause but so far I've been unsuccessful.

[SA-22C]

$ git bisect bad
7ee6d7b is the first bad commit
commit 7ee6d7b
Author: profezzorn [email protected]
Date: Tue Jun 25 21:42:55 2019 -0700

give new sound effects lower priority to avoid underflows

sound/buffered_wav_player.h | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)

Matthew@DESKTOP-PGUMJA9 MINGW64 ~/Desktop/proffieosbugfix/ProffieOS ((7ee6d7b...)|BISECTING)

Back to the underflow commit.

[profezzorn]

Makes sense unfortunately.
That CL might not exactly cause the bugs, but it sure makes them worse...

[profezzorn]

Does it seem to happen more on some fonts?
Does it happen with the stock fonts? (That's probably what I'll be using when I try to reproduce this problem myself tonight...)

[SA-22C]

I just tested Dark Kyber and Smooth Fuzz. Both exhibited the same bugs. Easiest way to trigger the bugs is to hammer on the aux button to try and trigger rapid blaster shots. This will cause the motion chip timeout/reboot issue and glitch out the audio.

[profezzorn]

Good news/bad news: It's acting really wonky for me too.

[profezzorn]

I did a manual bisect and got the same result as you.
Now, if I could just figure out why....

[profezzorn]

Fixed in 9cb2b6c I think. Please try it out and let me know. I will be releasing a new BETA shortly.