Comments (20)
Yep!
- Create a new file under
include/utils
calleddata_conversion.hpp
(I think this title is a better reflection of the fact that we're converting cases of characters – we could add other data conversion functions later). - In that file add two functions:
make_upper_case()
andmake_lower_case()
. The random number generation can go in a different file later on. - Add unit tests for these functions under
test/utils
in a file calleddata_conversion.cpp
. - If you're having trouble figuring out what the tests should look like, look at other testing files to get an idea how they work.
Let me know if you have any questions. 🙂
from proalgos-cpp.
Okay..Thanks for the explanation !
from proalgos-cpp.
from proalgos-cpp.
I am on it!
from proalgos-cpp.
@mrKappen Great! Also, if you're new to the repo and want to get your feet wet, a great way to do that is to migrate an algorithm to the new organization scheme, à la #201 and #202. Let me know if you have any questions.
from proalgos-cpp.
This also requires some thought as to what our goals would be regarding validation and how we would want to implement it in the project.
from proalgos-cpp.
I am interested and new to open source
from proalgos-cpp.
Great! Have a look at PR #209. A lot of the work is already done but it was closed automatically a while ago (there were merge issues that were never sorted out).
from proalgos-cpp.
Alright ! I can't find the file .
from proalgos-cpp.
Alright ! I can't find the file .
Try this: https://github.com/ProAlgos/ProAlgos-Cpp/pull/209/commits#diff-264aaf8546723aaccf7ce2e80d46ae3f
from proalgos-cpp.
Alright ! I can't find the file .
Try this: https://github.com/ProAlgos/ProAlgos-Cpp/pull/209/commits#diff-264aaf8546723aaccf7ce2e80d46ae3f
Okay ! I am looking where the commit conflicts are present .
from proalgos-cpp.
Might be easiest to just add the file from scratch rather than trying to manage conflicts. I think the folder organization is good, though. include/utils/data_validation.hpp
. I think it would be better to separate the random number generation into a different file. And of course we'll want to add unit tests for anything we add.
from proalgos-cpp.
Okay . So , just to be clear .
I have to make a new file in the include/utils directory . And I have to add data validation functions in this file along with unit tests !
from proalgos-cpp.
This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.
from proalgos-cpp.
I would like to know whether I can still contribute??
from proalgos-cpp.
I would like to know whether I can still contribute??
Definitely. Just reference this issue in your PR.
from proalgos-cpp.
Opened a PR for upper/lower case ^ 🥳 and hopefully it closes this issue unless if random int/double still required : ) but I think they are different problems random != conversion 🤔
from proalgos-cpp.
@alxmjo Sorry for the mention. Please can you review my pull request, I would appreciate your feedback. Thank you.
from proalgos-cpp.
I am interested in contributing to this issue. Also, I am new to open source.
from proalgos-cpp.
Hi @alxmjo I am interested in contributing to this repo as my first PR.
from proalgos-cpp.
Related Issues (20)
- add "longest common subsequence in the given strings" problem
- add segment tree data structure HOT 2
- Greedy algorithms. HOT 1
- Algorithm for binary tree traversal HOT 3
- Addition in data structures : AVL tree HOT 1
- Fix radix sort HOT 2
- Adding a new backtracking algorithm HOT 1
- Want to add documentation for linked list HOT 1
- Kth largest element in an array using priority queues HOT 3
- Euclidean algorithms HOT 1
- Euler's Totient HOT 1
- Implement BFS and DFS HOT 1
- windows version fails to build HOT 2
- queue and stack leak HOT 2
- two algorthims fail -fsanitize = address HOT 3
- Lacking documentation in linked list and other minor changes in the README HOT 1
- Addition of graph based Algorithms HOT 3
- AVL Tree Implementation HOT 1
- Implementation for Max Flow Problem
- Knight's Tour Problem HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proalgos-cpp.