Coder Social home page Coder Social logo

Comments (3)

rrrliu avatar rrrliu commented on July 2, 2024 1

All good - I'm out today but have a lot of time tomorrow to fix!

from halo2curves.

huitseeker avatar huitseeker commented on July 2, 2024 1

@CPerezz since we have both a merge queue and #54, we may want to close this.

from halo2curves.

huitseeker avatar huitseeker commented on July 2, 2024

This should be fixed in #54, but for the purpose of avoiding this sort of issue occurring again, perhaps this repo could use a GH merge queue?

TL;DR: this alleviates merge mistakes and time-of-fork vs. time-of-merge CI discrepancies by running CI as part of the merge process.

https://github.blog/changelog/2023-02-08-pull-request-merge-queue-public-beta/
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#triggering-merge-group-checks-with-github-actions

The CI changes are ~3 lines which I can totally tack on #56
(there are settings changes in the branch protection rules, which an admin of the repo would have to do ofc)

from halo2curves.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.