Coder Social home page Coder Social logo

Comments (1)

CPerezz avatar CPerezz commented on July 20, 2024

While porting secp256k1 I noticed the following:
Now PrimeField requires to be passed MULTIPLICATIVE_GENERATOR and ROOT_OF_UNITY.

MulGen is easy to derive using in Sage:

sage: GF(0xfffffffffffffffffffffffffffffffffffffffffffffffffffffffefffffc2f).primitive_element()
3

From this, we should be able to derive the Root of Unity. By doing:

Zp=Integers(0xfffffffffffffffffffffffffffffffffffffffffffffffffffffffefffffc2f)
sage: mul_gen = Zp(3)
sage: root_unity = Zp((mul_gen^(modulus -1)))
sage: root_unity
1

This means, that INV_ROOT_UNITY which was equal to 0 previously in the implementation was wrong as it should be 1.

Currently investigating this.

from halo2curves.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.