Coder Social home page Coder Social logo

Comments (7)

CPerezz avatar CPerezz commented on July 20, 2024

@davidnevadoc (and possibly others) will do some checks to the paper and discuss whether to go for an implementation as this requires to change the macros that implement everything for the curves.

from halo2curves.

zhenfeizhang avatar zhenfeizhang commented on July 20, 2024

Sounds good.

My demo has shows that both the group law can be integrated to both arkworks and halo2.
The tricky part here is that it requires standard projective coordinates, while arkworks/halo2 both uses jacobian coordinates.

I see two way to move forward

  1. have a simple MSM api that internally use RCB15 -- this is where performance is critical anyway -- and leave the rest untouched. This is simpler and can be done quite quickly
  2. to completely redo the curve trait which may take quite some time

Option 1 could serve as a temp patch until 2 is ready

from halo2curves.

zhenfeizhang avatar zhenfeizhang commented on July 20, 2024

updates: it looks like arkworks 0.4.0 uses 9 mul, incomplete version over jacobian coordinates.

maybe that is a better choice as it doesn't require a change of coordinate system

no arkworks also used 16 mul version

from halo2curves.

CPerezz avatar CPerezz commented on July 20, 2024

I think @kilic has already started to implement the Field encoding required for this. So we should be able to adopt it soon.

from halo2curves.

zhenfeizhang avatar zhenfeizhang commented on July 20, 2024

very nice!

from halo2curves.

davidnevadoc avatar davidnevadoc commented on July 20, 2024

I went for approach number 2 and switched to homogeneous coordinates. Are you aware of any downsides of using these instead of jacobian coordinates? @zhenfeizhang
Aside from a comment made in this issue regarding hash to curve, I haven't found anything.

from halo2curves.

zhenfeizhang avatar zhenfeizhang commented on July 20, 2024

I am not aware of any downside other than that the doubling is slightly more costly IIRC

from halo2curves.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.