Comments (8)
Please include the unminified sources. It's impossible to debug otherwise.
By the way it doesn't happen in Firefox for me, only Chrome.
from skrollr-menu.
Prinzhorn,
Sorry about that. I've updated both Skrollr and Skrollr-menu to unminified.
Here is the file I'm calling the init from:
http://prbbi.com/js/pr/pr-footer.js
from skrollr-menu.
This was introduced by ebb39bba#diff-14e11108e3fcf79bc01a46d211744495R141
I'm not sure though why I thought it would be a good idea to fall back to 0
when the popstate event doesn't deliver any data. For some reason Chrome does fire a popstate
when the page loads. I'm not sure about the consequences of ignoring popstate
events which lack skrollr-menu specific data (which are the the counterpart to a skrollr-menu triggered pushstate
).
from skrollr-menu.
Reading through #3 again maybe http://stackoverflow.com/questions/10742422/prevent-browser-scroll-on-html5-history-popstate was the reason for that. Because if I remove that code, then Chrome will scroll to the anchor by itself, which is not desired especially on mobile where this would break the page...
from skrollr-menu.
I'd need to take a closer look at this, but I'm busy. Maybe someone can play around with it and see what happens if the popstate is ignored, if it doesn't contain skrollr data.
from skrollr-menu.
I am having the same exact issue, but i am not good enough to work out a solution. Hope someone can find a workaround soon!
edit: btw i am on a very tight schedule and need a fix asap (i would also gladly donate for the work if needed!)
i got some results simply by deleting the word "popstate" in the script, but then i get this: when clicking on an anchor from the first page menu (like productivity-and-performance-services.php#tire-pressure) i get to the correct section in the second page, but if i am already on the 2nd page and click the same link "productivity-and-performance-services.php#tire-pressure" it gets to a wrong position... while having a link and clicking #tire-pressure on the same 2nd page would work ok.
I could find a workaround to this as well (different links on different pages, so when i am on the 2nd page the menu links will point just to the #tire-pressure and not to the full productivity-and-performance-services.php#tire-pressure link) but there must be a better way. Also removing "popstate" might have side effects i am not aware of.
..hope i explained well enough!
from skrollr-menu.
Same issue here: http://eudes.es/nova/test/index.html#organizar-evento
When loaded, page jumps to hash and immeditely afterwards jumps to the top.
Also, on mobile chrome there's a different issue:
When loaded the page jumps to hash, but you can't scroll up from there, only down. The size of the frame is the usual (whole page), but on the top of the page is the hashed position so you have half a blank page from the footer down.
from skrollr-menu.
Has anyone found a solution yet?
from skrollr-menu.
Related Issues (20)
- complexLinks not working correctly HOT 1
- skrollr-menu not working on mobile HOT 1
- Skrollr-menu scrolls to same location based on handlelink
- skrollr.menu.click(link) not working HOT 1
- Doesn't work HOT 2
- Scroll or Jump to the position HOT 1
- Hash URLs not loading properly on page load HOT 2
- Add bower.json manifest file HOT 1
- data-menu-offset percentage offset HOT 3
- Wrong version of Minified library in release 1.0.1 HOT 1
- Scrolling is not working, even though everything seems to be configured properly
- Enable Sourcegraph
- Add skrollr-menu to cdnjs.com HOT 1
- No support for require.js HOT 1
- url plus hash not working HOT 2
- problem in mobile device
- /dist/ contains wrong files HOT 1
- Webpage doesn't scroll as in demo when click on navigation links HOT 2
- handleLink buggy on safari iOS
- Hashes always appear in URL
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skrollr-menu.