Comments (2)
felker
commented on July 20, 2024
I would suggest making a feature branch, say tbl_reader, separate from your eos branch, and review it with the radiation developers. A standalone PR from tbl_reader to master would probably make sense before you merge the reader into eos.
Regarding moving parameter_input.* to src/inputs/ with the new files, this seems logical. The only required changes I can foresee involve modifying:
#include "../parameter_input.hpp"in many files.
from athena.
stale
commented on July 20, 2024
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from athena.
Related Issues (20)
- Resurrect Princeton Jenkins server HOT 7
- Convert Travis CI jobs into GitHub Actions
- Fix unsafe SIMD in relativistic Riemann solvers HOT 2
- Is this pdata->pnext supposed to be pnew->pnext here?
- Merge GR radiation transport
- Remove unused DEBUG macro HOT 4
- Use a uniform convention for boundary condition input parameters HOT 4
- Errors of linear Alfven wave for RK3+PPM (xorder=3) are much smaller than those in Athena++ paper
- Leftovers from merge non-relativistic radiation transport: add more output switches, derive IMRadTaskList, etc. HOT 7
- Timestep is incorrect for some GR metrics HOT 4
- Leftover chemistry fixes HOT 2
- Inconsistency in documentation of user-defined source terms? HOT 5
- Remove extraneous DeleteAthenaArray() calls HOT 3
- Access ParameterInput instance from user boundary conditions HOT 2
- Array indexing errors in llf_mhd_rel_no_transform.cpp HOT 2
- Leftover cosmic ray transport and diffusion changes HOT 1
- MHD shearing box has artifacts with SMR HOT 3
- athena_read allocates unnecessarily large amount of memory HOT 1
- Segmentation fault with shearing box and multiple meshblocks HOT 1
- Trouble running the configure script on MacOS terminal HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from athena.