Kit updates about react

[emplums]

Update!

I've merged in @broccolini 's changes in #72 and using the _app.js file + importing the Index component from docs.js seems to have fixed all our issues regarding reloading! 🎉 🎉 🎉

Going to work on getting permalinks working next!

[emplums]

Update on this for the team! @primer/ds-core

TLDR; I've got HMR mostly running, the fix was to rename the index.js file in /examples to something besides index, but that creates another issue with the base page that loads up when x0 is started being an unstyled page just showing all the files in /examples. Permalinks still aren't working ☹️ It's been a bit difficult understanding whether these issues are x0 issues, issues with me adding react-router to the mix, or issues with GitHub pages. I've been running into a bit of friction with the documentation on x0 + Kit being a little sparse since they are relatively new projects. I've messaged Jackson again and am going to keep digging today!

Update

I got HMR working again by renaming the index in the examples folder to something else, then changing x0 config's basename to '/', but I'm running into a few issues!

• When running x0 dev examples -op 8888 , I get taken to an unstyled index page listing all the files in my examples folder, since I don't have an index in that folder anymore. If I try running x0 dev examples/docs.js -op 8888 instead, the first load brings me to the examples/docs.js like I'd like it to, but when HMR kicks in after a change, it brings me back to the unstyled page listing the files in examples/docs.js. The URL in the browser is correct though (ex. [http://localhost:8888/docs/primer-react/Box] [name of index file/name of library/name of example]).

• I did set up a in my examples/docs.js file (previously examples/index.js) and I'm curious if that might be causing the issue here? Jackson mentioned that x0 already has routing set up, but it looks like that's just for routing in between Example components in a Library, I'm assuming that wouldn't work out of the box for just simple routing between components from the index page (ex. I have a Demos Library, Components Library, and Sandbox I'd like to add to the top navigation)

• I also had to set the basename config for x0 to / in order to get the docs to build, not sure if that is having something to do with it?

• When we publish our static builds to GitHub Pages, navigation works around Kit, but if I copy the link and paste it in a different tab, I get a 404. Honestly not sure if this is a x0 issue or a GitHub Pages issue

[shawnbot]

Done in #77.