Coder Social home page Coder Social logo

Cross-reference about octicons-v2 HOT 10 CLOSED

primer avatar primer commented on September 1, 2024
Cross-reference

from octicons-v2.

Comments (10)

colebemis avatar colebemis commented on September 1, 2024 3

I think the consensus is to use option 2. Here are the 16px and 24px versions:

16px 24px
reference reference (1)

I'm happy to move forward with these 👍

from octicons-v2.

sophshep avatar sophshep commented on September 1, 2024 2

@sophshep mentioned in Slack that a 💬 icon might be more appropriate here. I'm going to give that a try.

Additional reasoning:

  • It should be closer to "mention" than "link" since it often means there is additional context to be found alongside the reference
  • Other icons in the timeline show the medium in which the action took place (on a project board, for example), so this one should reference a comment
  • It feels more human & action oriented, especially next to a user's avatar

from octicons-v2.

ashygee avatar ashygee commented on September 1, 2024 1

@colebemis I like the speech bubble you created with the arrow because it feels stronger is the sentiment of referencing a conversation from elsewhere.

The arrow makes me think it's going to be an external link or that it will open in a new window.

@sophshep I'm wondering if the arrow came from the other side if it would feel different from going to another location.

But that being said I agree with you and @sophshep and also think the speech bubble alone can work as well.

from octicons-v2.

colebemis avatar colebemis commented on September 1, 2024

Currently, we use the bookmark icon for "cross-reference" in the timeline:
image

But I think a link icon would make more sense:

image

16px 24px
link (1) link

What do y'all think?

from octicons-v2.

colebemis avatar colebemis commented on September 1, 2024

@sophshep mentioned in Slack that a 💬 icon might be more appropriate here. I'm going to give that a try.

from octicons-v2.

ashygee avatar ashygee commented on September 1, 2024

It feels more human & action oriented, especially next to a user's avatar

@sophshep I love this reason to opt for something closer to 💬!

@colebemis It really is in line with the use much more than linking. With 🔗 sometimes it feels not as dynamic or a part of the conversation. It also makes me think I'll be taken "out" rather than referencing something "in" discussion.

from octicons-v2.

ashygee avatar ashygee commented on September 1, 2024

Screenshot 2019-09-30 12 48 30

@colebemis this is an example of what [Noun Project](https://thenounproject.com/term/reference/1708284) has as a reference example. I'm wondering what it might look like if it was the speech bubble with the arrow?

maybe something similar to this?
Screenshot 2019-09-30 12 55 49

from octicons-v2.

colebemis avatar colebemis commented on September 1, 2024

@sophshep @ashygee Here's what it would look like as a speech bubble:

image

16px 24px
comment comment (2)

I like the speech bubble 😄 I think it reads more like "people are talking about this issue/pull request" which is good 👍

I'm wondering what it might look like if it was the speech bubble with the arrow?

I tried this out (see below), but I think it makes the icon a little cluttered. I think a simple speech bubble gets the job done in this case.

Frame 2 326

from octicons-v2.

sophshep avatar sophshep commented on September 1, 2024

I like speech bubble too!

I'm wondering what it might look like if it was the speech bubble with the arrow?

The arrow makes me think it's going to be an external link or that it will open in a new window.

from octicons-v2.

ashygee avatar ashygee commented on September 1, 2024

@colebemis posted these options in the channel:
image (6)

Option 2 feels the strongest out of these 4. Here is a UI example

Frame 3

from octicons-v2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.