List selection color is stronger than focus + selection about github-vscode-theme

[simurai]

@isidorn thanks for raising this issue.. 🙇

Selection + focus are stronger than just selection and thus the color should be stronger, not lighter.

Hmmm.. yeah, this seems tricky to fix. I couldn't find a way to change the "selected, but unfocused" color. 🤔 It seems that it gets automatically darkened by 10% based on the list.activeSelectionBackground color. I assume that works ok for dark themes, but not really for light themes that use a selection color that is slightly darker than the background.

An option would be to make the list.focusBackground color even darker than the darken(listActiveSelectionBackground, 0.1). But that feels a bit too dark:

Or something like white text on a blue background, but it's still a bit odd that when the focus moves away from the selection that it becomes "stronger" (darker).

Would it be possible if VS Code would use darken() for dark themes and lighten() for light themes?

Or add a list.focusAndSelectionBackground token? But that's probably a lot more work. 😬

[simurai]

This should be improved by now:

Screen.Recording.2022-07-15.at.14.14.30.mov