Coder Social home page Coder Social logo

Comments (3)

simurai avatar simurai commented on June 10, 2024

What's the steps to reproduce the issue inside VS Code? I tried the following with the example code of:

# Jinja2 in a comment should not display as commented out
# foo {% foo %}
foo {% foo %}
  1. Add a new file with .jinja2 extension
  2. Let VS code auto-detect the language

It picked C, but I assume an additional extension needs to be installed?

Screen Shot 2023-01-03 at 16 26 38

from github-vscode-theme.

MetRonnie avatar MetRonnie commented on June 10, 2024

It needs a VSCode language that supports embedded languages. For example Cylc (cylc.vscode-cylc) supports embedded Jinja2 (no need to have any Jinja2 language installed).

I think the key difference between GitHub theme and Default Dark+ is that the former just gives a comment.line.cylc, meta.embedded.block.jinja-scoped token a foreground colour of comment whereas the latter defers to the usual foreground colours for a non-comment meta.embedded.block.jinja token, if that makes any sense (I've updated the OP slightly to help clarify this).

from github-vscode-theme.

simurai avatar simurai commented on June 10, 2024

Maybe we could be less strict with this line:

- "meta.embedded.expression"
+ "meta.embedded"

Then the meta.embedded scope overrides the comment scope for lines with meta.embedded.block.jinja:

Before After
Screen Shot 2023-01-17 at 17 06 03 Screen Shot 2023-01-17 at 17 06 59

from github-vscode-theme.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.