Comments (5)
stefankp
commented on May 2, 2024
2
@JoshBowdenConcepts exactly. Because it performs an action and doesn't lead to another URL.
from brand.
rezrah
commented on May 2, 2024
1
Potential solution:
Enable as prop of type a | button for MinimalFooter.Link, similar to other polymorphic components in Primer Brand.
from brand.
stefankp
commented on May 2, 2024
Works for me, but the button wouldn't have the href attribute.
from brand.
rezrah
commented on May 2, 2024
Works for me, but the
buttonwouldn't have thehrefattribute.
👍 We'll handle that using conditional types
from brand.
JoshBowdenConcepts
commented on May 2, 2024
Just to clarify here! Is the intention for this content to be a Button but look like a Link, as you have shown on the Enterprise page?
from brand.
Related Issues (20)
- 🐛 [BUG] - Animating hero (above the fold) HOT 2
- [Accessibility] Improve `SubdomainNavBar` keyboard navigation
- [Accessibility] After resizing page to 320*256 focus moving to the hidden elements while navigating with the tab key. HOT 2
- [Accessibility] Visual name and aria-label are different for 'GitHub' control HOT 1
- [Accessibility] Add a "Skip To Content" button to `SubdomainNavBar`
- [Accessibility] Improve overflowing of `SubdomainNavBar` on mobile
- Prose: support additional HTML tags HOT 2
- Missing `Animation.module.css` in the build and published artifact HOT 2
- Logo suite with many logos + reduced motion HOT 2
- Add support for directional border to Box
- 🐛 [BUG] - Spacing on River Breakout HOT 3
- [Feature request] Add support for other fonts
- 🐛 [BUG] - FAQ Item click area overlaps with FAQ Anser
- 🐛 [BUG] - InlineLink does not inherit size HOT 7
- [Feature request] Add support for multiple `AnchorNav.Action` HOT 3
- 🐛 [BUG] - `Prose`'s unordered lists do not play well with dark mode
- [Suggestion]: Add documentation around Stack breakpoints
- 🐛 [BUG] - Regression of `leadingVisual` on `TextInput` HOT 1
- 🐛 [BUG] - Button Gap on Medium Size should be 4px (0.25rem) instead of 12px. HOT 5
- [Feature request] Allow `<Label>` in River + Bentos HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brand.