Rundown #3 (JSX) about prettier

[vjeux]

Should jscodefmt sort JSX props? I heard refmt does something like that. I haven't tried it yet.

Rewrite expression using ternary operator

Those are not safe operations to do in JavaScript. They may change the actual output of a program. So it's probably better to have a lint rule do them.

[jlongster]

Good points, a few of them are already fixed on master from other comments, and the rest get into some difficult heuristics but it's worth seeing what we can do. I spent some time on JSX but there's definitely more things we could do.

I need to reduce the amount of time I'm working on this soon. I will slowly tweak things over time but it'd be great if those who proposed changes could actually open PRs. I will write more docs soon about how the printer works to aid this.

[vramana]

@vjeux Makes sense.

[jlongster]

Probably a space before ( for anonymous generator functions

I don't think I want to do this. For consistency we'd have to put a space with anon functions too (function () which starts to get annoying. I don't think function*() { ... } looks bad and is consistent. This is one of those things where once you see if a few times you'll think it looks fine.

[wmertens]

For the ...(foo && bar || meep) case, at least insert parens: ...((foo && bar) || meep). Operator precedence is sometimes surprising.

[vramana]

I am closing this to reduce noise since people have filed individual issues for most of the issues listed here.