Coder Social home page Coder Social logo

Comments (4)

jlongster avatar jlongster commented on May 1, 2024

Can you expand on this more? I don't remember exactly what this behavior is.

from prettier.

vramana avatar vramana commented on May 1, 2024

refmt would normally remove all the blank lines btween the let declarations. So,

let a = 2;

let b = 3;

will become

let a = 2;
let b = 3;

But if you use a comment /** */ between them i.e,

let a = 3;
/** My Comment */
let b = 4;

It inserts a new line above the comment.

let a = 3;

/** My Comment */
let b = 4;

from prettier.

jlongster avatar jlongster commented on May 1, 2024

Ah interesting. Today I landed rules for newlines, and it keeps the original newlines. Meaning if you had

let a = 2;
let b = 3;

that's what it would output. However if you had:

let a = 2;

let b = 3;

It would output that as well. Lastly, if you have multiple blank lines like:

let a = 2;



let b = 3;

It will collapse them into a single newline.

I don't think we can be as opinionated as refmt because there are so many existing JS coding styles. I tried coming up with automatic ways to insert newlines, but it's pretty difficult.

I like the idea that it encourages you to document in order to group things up. I'm open to talking more about this, so I'll leave this open. @vjeux what do you think?

from prettier.

vjeux avatar vjeux commented on May 1, 2024

I know about the refmt way of doing things but I still think that it's better to preserve lines inputted by the user. It seems super arbitrary to have to add a comment to make sure lines are displayed the way you want. Also, adding more comments is not a good thing in itself. I'd rather have comments on why things are done this way rather than commenting on how each line works.

from prettier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.