Comments (4)
Can you expand on this more? I don't remember exactly what this behavior is.
from prettier.
refmt would normally remove all the blank lines btween the let declarations. So,
let a = 2;
let b = 3;
will become
let a = 2;
let b = 3;
But if you use a comment /** */ between them i.e,
let a = 3;
/** My Comment */
let b = 4;
It inserts a new line above the comment.
let a = 3;
/** My Comment */
let b = 4;
from prettier.
Ah interesting. Today I landed rules for newlines, and it keeps the original newlines. Meaning if you had
let a = 2;
let b = 3;
that's what it would output. However if you had:
let a = 2;
let b = 3;
It would output that as well. Lastly, if you have multiple blank lines like:
let a = 2;
let b = 3;
It will collapse them into a single newline.
I don't think we can be as opinionated as refmt because there are so many existing JS coding styles. I tried coming up with automatic ways to insert newlines, but it's pretty difficult.
I like the idea that it encourages you to document in order to group things up. I'm open to talking more about this, so I'll leave this open. @vjeux what do you think?
from prettier.
I know about the refmt way of doing things but I still think that it's better to preserve lines inputted by the user. It seems super arbitrary to have to add a comment to make sure lines are displayed the way you want. Also, adding more comments is not a good thing in itself. I'd rather have comments on why things are done this way rather than commenting on how each line works.
from prettier.
Related Issues (20)
- prettier formatWithCursor very slowed when use with *.min.js HOT 1
- [CSS] Remove extra indent for multiline `:where`, `:is` and `:not` selectors
- Ranged formatting for `yield` in iterators breaks with tuples HOT 1
- Ugly logical expression break in Vue `v-if`
- [bug] [yaml] list indent fix can result in invalid yaml or change the meaning of existing yaml
- HTML 'strict' whitespace sometimes injecting a '>'
- Bug with type assertion around yield expression
- Prettier breaks Markdown alert syntax
- Prettier changes meaning of HTML+JS code when using tags that look like self-closing HOT 3
- Comment in last line of YAML files gets leading newline trimmed HOT 1
- Typescript: Prettier incorrectly breaks up constructor properties from modifiers when there is a decorator and comment before it HOT 1
- [Documentation] Pre-Commit Hook Usage case caveat
- Still the error "Error: Comment "Hello" was not printed. Please report this error!" even though I have added a comment in the Doc. HOT 1
- [JavaScript] Comments between ternary operator formatting result is ugly HOT 2
- Prettier wrong formatting of Angular flow HOT 3
- Markdown undesirable formatting behaviour when new text added to paragraph HOT 1
- Error when file names HOT 4
- Can we have a CLI flag that allows ignoring .gitignore and/or .prettierignore please? HOT 2
- Unstable block comment for implemented interfaces (TypeScript) (moved and non-idempotent)
- Markdown lists with extra indent lead to unstable formatting behavior
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prettier.