cases in switch statements not indented about prettier

[dvlsg]

Just some additional insight into why it may be helpful to indent case statements:

// without braces for case
const val = 'bar';
switch (val) {
case 'foo':
  const b = 'bar';
  break;
case 'bar':
  const b = 'baz'; // SyntaxError: Identifier 'b' has already been declared
  console.log(b);
  break;
} // looks okay

// with braces for each case, no indentation
const val = 'bar';
switch (val) {
case 'foo': {
  const b = 'bar';
  break;
}
case 'bar': {
  const b = 'baz'; // works!
  console.log(b);
  break;
}
} // two braces in a row at the same indent looks odd

// with braces for each case, with indentation
const val = 'bar';
switch (val) {
  case 'foo': {
    const b = 'bar';
    break;
  }
  case 'bar': {
    const b = 'baz'; // works!
    console.log(b);
    break;
  }
} // looks "normal" to me

[gre]

I was about to raise a bug that case have an extra indenting level and found that this issue is actually producing this "bug" 😄

Is there an available option to get back to the switch to be aligned with case ?
I'm used to this convention and I thought it was standard? ESlint complaints that the switch is supposed to be aligned with case.

There is a whole debate on internet about this, so I guess it should be made an option?

[azz]

My opinion is that due to case ending in a :, it should be treated the same as a label, and not indented.

[mrspeaker]

Yeah, this is annoying (but still, worth it 'cause Prettier is excellent) - I have to run it, then go re-un-indent the case statement, then save the file every time.

Seeing as the original Prettier behavior was "correct" then "fixed" in a PR because of someone's personal preference - it feels like this should be an option.

[bakkot]

You can configure eslint to match prettier.

---

I strongly suspect the style prettier currently produces is by far the more common, and that most people will not refuse to use prettier because it enforces this style (although of course some people will). It is, for example, the style recommended by AirBnB, Google, and standard-js. As such, this seems like a textbook case where prettier should resist adding configuration. Remember, prettier is supposed to be opinionated!

Try this style; I bet you'll get used to it quick.

[mrspeaker]

I could get used to ANY style quickly if I had to - but personally ESLint is my boss and I have to make my tools work around it. I agree it doesn't have to be an option but it should be opinionated that case statements are labels and shouldn't be indented, just as the original author made it.

It's not a big deal though - I try not to use switch statements too often, so it's easy to fix them each time.