Coder Social home page Coder Social logo

Comments (6)

vjeux avatar vjeux commented on May 1, 2024 1

@despairblue thank you! This is great! Shouldn't be too hard to make work.

from prettier.

vjeux avatar vjeux commented on May 1, 2024

Repro case

https://jlongster.github.io/prettier/#%7B%22content%22%3A%22someVeryLongMethodObjectName%5Cn%20%20.withSomeVeryLongObjectKey%5Cn%20%20.withSomeVeryLongObjectKey%5Cn%20%20.andAnotherLongKey%3B%22%2C%22options%22%3A%7B%22printWidth%22%3A80%2C%22tabWidth%22%3A2%2C%22singleQuote%22%3Afalse%2C%22trailingComma%22%3Afalse%2C%22bracketSpacing%22%3Afalse%7D%7D

from prettier.

despairblue avatar despairblue commented on May 1, 2024

@JakeCoxon If you want to give it a shot you might be interested in the discussion in #212 and my take on this (which created a lot of other issues) in #217.

I'd still like to see a solution for this. Chai assertions are another thing that suffer from this.

I wonder if there is a way to only add an softspace after a dot if the currently printed line would exceed the max line length with the next token. But I think that's not easy at all and not performant.

from prettier.

vjeux avatar vjeux commented on May 1, 2024

@despairblue do you mind giving a real-world example of chai assertions that do not look good? It's usually better for this kind of things to look at real code rather than make up examples.

from prettier.

despairblue avatar despairblue commented on May 1, 2024

@vjeux sure this would be a small one. I'd rather see the left case instead of the right one.

Or this one which is a little longer.

from prettier.

vjeux avatar vjeux commented on May 1, 2024

With #462 it looks like

if (testConfig.ENABLE_ONLINE_TESTS === "true") {
  describe("POST /users/me/pet", function() {
    it("saves pet", function() {
      function assert(pet) {
        expect(pet).to.have.property("OwnerAddress").that.deep.equals({
          AddressLine1: "Alexanderstrasse",
          AddressLine2: "",
          PostalCode: "10999",
          Region: "Berlin",
          City: "Berlin",
          Country: "DE"
        });
      }
    });
  });
}

which is better. But we should also be able to break the .to.have.property()

from prettier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.