Coder Social home page Coder Social logo

Comments (6)

gaearon avatar gaearon commented on May 1, 2024 2

Here, IMO the best style would be the one that optimizes for diff readability on changes.
Like the one in the OP post.
Probably worth doing for any elements that don't fit within a single line completely.

from prettier.

wmertens avatar wmertens commented on May 1, 2024

And don't forget about this form:

const FooForm = ({colour}) => {
   const method = 'GET'
   return (
      <BaseForm {...{
        url: '/auth/google',
        method, colour
      }}/>
   )
}

from prettier.

ericclemmons avatar ericclemmons commented on May 1, 2024

Similarly, I tested:

const render = ({ styles }) => (
  <div style={styles} key="something">
    Keep the wrapping params. Put each key on it's own line.
  </div>
);

which results in:

const render = ({ styles }) => <div style={
  styles
} key="something">
  Keep the wrapping params. Put each key on it's own line.
</div>;

from prettier.

rattrayalex avatar rattrayalex commented on May 1, 2024

I'm going to try to tackle this now.

from prettier.

rattrayalex avatar rattrayalex commented on May 1, 2024

The example by @ericclemmons now compiles to:

const render = ({ styles }) => <div style={styles} key="something">
  Keep the wrapping params. Put each key on it's own line.
</div>;

which is an improvement, but I agree the parens should be maintained. I'll open a separate issue for that if one doesn't already exist, and try to tackle soon.

(note that improvement is probably unrelated to my modification, I didn't check)

from prettier.

vramana avatar vramana commented on May 1, 2024

I am closing this in favour of #73. Please continue the discussion in that thread.

from prettier.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.