Comments (2)
Just FYI: We have a similar test which uses is based on the same test case https://github.com/prestodb/presto/blob/master/redis-hbo-provider/src/test/java/com/facebook/presto/statistic/TestHistoryBasedRedisStatisticsTracking.java but this is not flaky.
I think this is because we use a test redis client for this test instead of the inmemory handling done. If needed we can combine these 2 and move to presto-tests
from presto.
I looked into #22204 and #22118 during the hackathon, and had a very difficult time reproducing the issue (managed once out of >30k runs).
my suspicion is actually that it's a very slightly flaky feature rather than a flaky test, though i would expect this to affect redis just as much unless it's run in a different test job that happens to encounter this issue less. Basically, I suspect that sometimes the runtime stats from certain nodes from certain operators don't get reported to the coordinator. I only have the test logs to go on, but you can see in this stack trace in this issue that the output node is using hbo stats with the correct output row count, but the test is testing the fliter row count and here the tablescan and filter nodes are using cbo stats.
In the one time i was able to reproduce the issue locally #22204 (comment), we had cbo stats for the scan, and hbo for the filter and output. the hbo stats were 0 for the filter node, but the output node had correct hbo stats.
from presto.
Related Issues (20)
- Wrong results for count (and probably correlated subqueries) over empty grouping sets
- Wrong timezone conversions for "America/Scoresbysund" HOT 8
- presto memory usage mechanism problem, after the execution of the calculation task, the memory usage is not reduced HOT 1
- Not able to build presto project HOT 9
- [native] Possible SEGV in HttpClient::createTransaction HOT 10
- Add a UDF for splitting array into slices of given length
- Add fail-fast function validation support for Presto C++
- Allow C++-defined system session properties
- Differential privacy primitives use insecure noise generation HOT 2
- Missing pushdown
- Flaky SingleStore tests HOT 1
- CI job SingleStore tests failing HOT 1
- Add ARM64 Support for Building Prestissimo Docker Image on Mac M1 HOT 8
- Backport https://github.com/prestodb/presto/pull/22926 into 0.285, 0.286 and 0.287 HOT 4
- Pushdown (partial) rowNumber under join
- Flaky test: TestMemoryManager.testReservedPoolDisabledMultiCoordinator
- Add documentation for Geospatial types in main types page HOT 5
- For each agg function with input param as <T>, Add an equivalent agg function with input param as array<T> HOT 1
- [docs] Combine the descriptions of session property with configuration property for history based optimization
- singlestore-dockerized-tests job is failing often HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from presto.