TestNoisySumGaussianRealAggregation.testNoisySumGaussianRealClippingSomeNoiseScaleWithinSomeStd about presto

[elharo]

I think the test is misunderstanding what standard deviation is and how it's calculated, though I might have to spend some time with a statistics book in hand to explain what's really going on here.

[rschlussel]

I'm still seeing this failure for the double version:

Error:  Tests run: 8285, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 1,461.751 s <<< FAILURE! - in TestSuite
Error:  com.facebook.presto.operator.aggregation.noisyaggregation.TestNoisySumGaussianDoubleAggregation.testNoisySumGaussianDoubleClippingSomeNoiseScaleWithinSomeStd  Time elapsed: 0.002 s  <<< FAILURE!
java.lang.AssertionError: Test: Inconsistent results with reversed channels, Expected: 42.7871001051494, actual: 48.01681405531419
	at org.testng.Assert.fail(Assert.java:110)
	at com.facebook.presto.operator.aggregation.AggregationTestUtils.assertFunctionEquals(AggregationTestUtils.java:138)
	at com.facebook.presto.operator.aggregation.AggregationTestUtils.groupedAggregation(AggregationTestUtils.java:351)
	at com.facebook.presto.operator.aggregation.AggregationTestUtils.assertAggregationInternal(AggregationTestUtils.java:124)
	at com.facebook.presto.operator.aggregation.AggregationTestUtils.assertAggregation(AggregationTestUtils.java:85)
	at com.facebook.presto.operator.aggregation.noisyaggregation.TestNoisySumGaussianDoubleAggregation.testNoisySumGaussianDoubleClippingSomeNoiseScaleWithinSomeStd(TestNoisySumGaussianDoubleAggregation.java:294)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.testng.internal.invokers.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:135)
	at org.testng.internal.invokers.TestInvoker.invokeMethod(TestInvoker.java:673)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethod(TestInvoker.java:220)
	at org.testng.internal.invokers.MethodRunner.runInSequence(MethodRunner.java:50)
	at org.testng.internal.invokers.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:945)
	at org.testng.internal.invokers.TestInvoker.invokeTestMethods(TestInvoker.java:193)
	at org.testng.internal.invokers.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
	at org.testng.internal.invokers.TestMethodWorker.run(TestMethodWorker.java:128)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:750)