Comments (3)
I prefer adding the missing SPLIT function overload for char type - varchar vs char is too subtle for users.
So I suggest for now, removing the CharType as suggsted on the original PR and open a separate issue to add SPLIT for CHAR type so we can make it more robust.
We are definitely not reverting the optimization.
from presto.
presto:di> select SPLIT(CAST('abc' AS CHAR(3)), 'a');
Query 20240229_013122_09457_ph8x5 failed: line 1:8: Unexpected parameters (char(3), varchar(1)) for function split. Expected: split(varchar(x), varchar(y), bigint) , split(varchar(x), varchar(y))
select SPLIT(CAST('abc' AS CHAR(3)), 'a')
from presto.
I prefer adding the missing SPLIT function overload for char type - varchar vs char is too subtle for users.
So I suggest for now, removing the CharType as suggsted on the original PR and open a separate issue to add SPLIT for CHAR type so we can make it more robust.
We are definitely not reverting the optimization.
Agreed on this path forward. Would you like to raise a PR?
from presto.
Related Issues (20)
- Backport https://github.com/prestodb/presto/pull/22926 into 0.285, 0.286 and 0.287 HOT 4
- Pushdown (partial) rowNumber under join
- Flaky test: TestMemoryManager.testReservedPoolDisabledMultiCoordinator
- Add documentation for Geospatial types in main types page HOT 5
- For each agg function with input param as <T>, Add an equivalent agg function with input param as array<T> HOT 1
- [docs] Combine the descriptions of session property with configuration property for history based optimization
- singlestore-dockerized-tests job is failing often HOT 1
- Getting error while building in intelli idea HOT 2
- How to build a custom connector?
- How to build and run presto in intellij idea? HOT 1
- [native] Flaky test TaskManagerTest.buildSpillDirectoryFailure HOT 2
- Writer scaling fails for Parquet with smaller files HOT 6
- Flaky test: TestNoisySumGaussianLongAggregation.testNoisySumGaussianLongClippingSomeNoiseScaleWithinSomeStd() HOT 1
- Iceberg $changelog read fails on table with only one snapshot version.
- Pushdown partial TopN and RowNumber into UNION
- Inline cosntant cross joins
- Allow Presto Coordinator to ignore (not throw) negative runtime metrics. HOT 1
- Update the MongoDB connector to support binData data type HOT 2
- Presto needs a modern functional testing framework that runs tests using real infrastructure
- [docs] fix warnings in doc build for resource-groups.rst HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from presto.