Coder Social home page Coder Social logo

Comments (3)

kaikalur avatar kaikalur commented on June 29, 2024

I prefer adding the missing SPLIT function overload for char type - varchar vs char is too subtle for users.

So I suggest for now, removing the CharType as suggsted on the original PR and open a separate issue to add SPLIT for CHAR type so we can make it more robust.

We are definitely not reverting the optimization.

from presto.

kaikalur avatar kaikalur commented on June 29, 2024
presto:di> select SPLIT(CAST('abc' AS CHAR(3)), 'a');
Query 20240229_013122_09457_ph8x5 failed: line 1:8: Unexpected parameters (char(3), varchar(1)) for function split. Expected: split(varchar(x), varchar(y), bigint) , split(varchar(x), varchar(y))
select SPLIT(CAST('abc' AS CHAR(3)), 'a')

from presto.

tdcmeehan avatar tdcmeehan commented on June 29, 2024

I prefer adding the missing SPLIT function overload for char type - varchar vs char is too subtle for users.

So I suggest for now, removing the CharType as suggsted on the original PR and open a separate issue to add SPLIT for CHAR type so we can make it more robust.

We are definitely not reverting the optimization.

Agreed on this path forward. Would you like to raise a PR?

from presto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.