Comments (3)
It's not a bug in array_sort itself, but in the lambda function that we are passing to it. Array_sort without a function argument sorts with NaN as the largest. This passes a function that does element comparison for the values, but < and = comparison with NaN always return false.
The relevant part of the sql function is here:
`array_sort(map_entries(map_filter(input, (k, v) -> v is not null)), (x, y) -> IF(x[2] < y[2], 1, IF(x[2] = y[2], IF(x[1] < y[1], 1, -1), -1)))`
from presto.
This is a great catch!
A side note, array_sort with a lambda is quite dangerous. It is very easy to write lambda that doesn't match implicit requirements (like in this case): https://velox-lib.io/blog/array-sort
from presto.
Note that map_top_n
is just a SQL function, so likely the bug or unexpected behavior is in one of its constituent functions (such as array_sort
).
from presto.
Related Issues (20)
- Improve scheduling for cte materialization queries by only blocking the cte consumers till producers have written
- CSE from AND/OR
- Inconsistent behavior of conjunction expression HOT 27
- Support non iceberg native types on iceberg connector HOT 3
- array_position doesn't support nulls while velox does
- Release 0.289 HOT 2
- Address CVE's from hudi-presto-bundle:0.14.0 jar
- Pushdown cross join with filter into union all
- Flakiness in TestIcebergDistributedHive.testLargeQuery HOT 9
- Prestissimo over reporting split/driver counts
- TestEventListener.testPrepareAndExecute is flaky HOT 1
- Incorrect and inconsistent behavior of Like with constant folding HOT 2
- Timestamp logical type annotation not being stored when written from presto hive HOT 1
- Refactor queueing-related classes in presto-main module to a new presto-dispatcher module
- `prestodb/presto-native` on Docker Hub lacks self-documentation
- Fork existing presto-elasticsearch connector and create a presto-elasticsearch-6 version in preparation for moving to Elasticsearch 7.x support. HOT 1
- Distinguish between partitioning for join vs agg
- Add Exchange before GroupId to improve Partial Aggregation
- Add a new scheduler + exchange rules to support multiple table scans in a single stage
- Add support for streaming TopN rank HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from presto.