Coder Social home page Coder Social logo

Comments (5)

 avatar commented on May 29, 2024

@eri-trabiccolo not urgent but it would be good if you could take a look at it.
Thanks !

from nimble-builder.

eri-trabiccolo avatar eri-trabiccolo commented on May 29, 2024

I don't seem to be able to reproduce this mmm

from nimble-builder.

eri-trabiccolo avatar eri-trabiccolo commented on May 29, 2024

You know that I didn't absolutely get the nature of this issue?! :D
I thought it was an issue with the Customizr modern theme.

Now I got it :D

from nimble-builder.

eri-trabiccolo avatar eri-trabiccolo commented on May 29, 2024

Hi @Nikeo,
so I implemented the lists style like in the Customizr-modern theme, with one exception:
I set the ul,ol margin-left from 3rem to 1.5rem, given the fact that the nimble builder will allow putting ul/ol in narrow containers.

Also, consider that the Customizr-modern lists style is pretty "specific" and, if you want, convoluted, and I'm not totally sure it should be taken as base for the nimble builder which can be used with whatever theme (so whatever layout, column and module width etc).
Probably a more simple styling (avoiding the li::before absolute positioning, the ol li counters etc.) might better suit the nimble purposes.

For this reason I've also added a "very simple" style (commented), based on the 2017 theme code, so that we can use that if we find the Customizr-modern style not versatile enough to look fine with most of the themes we're going to test.

In any case nested lists are hard to manage by default, IMHO, when you have no clue where they will be put.

from nimble-builder.

 avatar commented on May 29, 2024

OK.
I agree and I think that it might be even better to use the "conservative" code from the start, and comment the customizr like one.
Thanks

from nimble-builder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.