Coder Social home page Coder Social logo

Comments (13)

JoviDeCroock avatar JoviDeCroock commented on May 30, 2024 2

Everything under 0.10.x is not compatible with the 1.0.0 line of vite, I've contacted people at vite about this since there were no evident breaking changes in beta.12 so this might be a bug with export mangling, ...

This could also be related to how modules are loaded, ....

from prefresh.

JoviDeCroock avatar JoviDeCroock commented on May 30, 2024 1

This was fixed in [email protected]

from prefresh.

JoviDeCroock avatar JoviDeCroock commented on May 30, 2024 1

Good spot, seems like prepublishOnly didn’t run. Hope that’s not a changesets bug πŸ˜…

from prefresh.

Grafikart avatar Grafikart commented on May 30, 2024

It's not related with path change (I had the same bug before). It happens when I upgrade @prefetch/vite to 0.10.X.
If we rollback to 0.9.0 we loose hotreload but everything work again

from prefresh.

wiesson avatar wiesson commented on May 30, 2024

I have updated vite from 1.0.0-beta.11 and from 1.0.0-beta.12 onwards, the bug occurs

from prefresh.

cdbattags avatar cdbattags commented on May 30, 2024

@yyx990803 Any update on this bug? I'm guessing this is definitely due to export mangle?

Happy to assist however I can!

from prefresh.

wiesson avatar wiesson commented on May 30, 2024

Sorry to ask, but in my case it's still broken - do I need to update the config?

from prefresh.

JoviDeCroock avatar JoviDeCroock commented on May 30, 2024

@wiesson what's broken? I just installed the new vite version and it seemed to work πŸ˜… make sure it sais vite v1.0.0-rc.4 when you do vite. Also ensure you have the latest @prefresh/vite

from prefresh.

wiesson avatar wiesson commented on May 30, 2024

Hmm, not on my machine πŸ˜“

$ foo node --version               
v14.7.0

npm init vite-app foo --template preact
cd foo
npm install
npm run dev

Updated package.json

$ foo cat package.json 
{
  "name": "foo",
  "version": "0.0.0",
  "scripts": {
    "dev": "vite",
    "build": "vite build"
  },
  "dependencies": {
    "preact": "^10.4.6"
  },
  "devDependencies": {
    "@prefresh/vite": "^0.10.2",
    "vite": "^1.0.0-rc.4"
  }
}

Which looks good

$ foo npm run dev                            

> [email protected] dev /Users/wiese/Dev/foo
> vite

vite v1.0.0-rc.4
Port 3000 is in use, trying another one...

  Dev server running at:
  > Local:    http://localhost:3001/
  > Network:  http://192.168.0.80:3001/

buuut πŸ’₯
Screenshot 2020-07-31 at 16 37 00

from prefresh.

JoviDeCroock avatar JoviDeCroock commented on May 30, 2024

Hmm, we should move this issue to vite. It works just fine here πŸ˜… I'll try with a different node verison in abit

from prefresh.

JoviDeCroock avatar JoviDeCroock commented on May 30, 2024

@wiesson I just tried it with my own node v14 and it just works, quite confused at the moment πŸ˜…

from prefresh.

underfin avatar underfin commented on May 30, 2024

@JoviDeCroock. I notice this issue is fixed by 42ac94f. But install @prefresh/[email protected] code is @prefresh/[email protected].The code ( path.includes('node_modules') ) is lost.

from prefresh.

wiesson avatar wiesson commented on May 30, 2024

Thanks @underfin - I can confirm that this fixes the issue πŸ‘

from prefresh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.