Coder Social home page Coder Social logo

Comments (4)

prashaantt avatar prashaantt commented on August 11, 2024 1

Thanks for digging this up @kbrandwijk! I don't have ready access to a Windows machine to test this out. Would you mind submitting a PR from a PC that you've tested this on?

from node-tdd.

prashaantt avatar prashaantt commented on August 11, 2024

@orgi I've seen the glob behave slightly differently on Windows. It's part of VS Code and I have no control over it. Also see #5 (comment).

from node-tdd.

kbrandwijk avatar kbrandwijk commented on August 11, 2024

Unfortunately, I can confirm that glob patterns are still not working on Windows. Maybe it's an idea to use https://code.visualstudio.com/docs/extensionAPI/vscode-api#RelativePattern instead of resolve? I'm not sure if it will fix things...

Update: upon further research, I'm positive that changing:

const globPath = resolve(workspace.rootPath, NodeTDD.getConfig<string>(config.GLOB));
into:

const globPath = new RelativePattern(workspace.workspaceFolders[0], NodeTDD.getConfig<string>(config.GLOB))

should do the trick, because path.resolve() will never result in more than one folder on Windows. Also, since the glob pattern uses /, path.posix.resolve() would be needed, but would still give you a single folder.

from node-tdd.

kbrandwijk avatar kbrandwijk commented on August 11, 2024

@prashaantt Please see the referenced PR. I have tested this on Windows only with a deep tree and the default glob setting, and it works like a charm.

from node-tdd.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.