Comments (4)
Thanks for digging this up @kbrandwijk! I don't have ready access to a Windows machine to test this out. Would you mind submitting a PR from a PC that you've tested this on?
from node-tdd.
@orgi I've seen the glob behave slightly differently on Windows. It's part of VS Code and I have no control over it. Also see #5 (comment).
from node-tdd.
Unfortunately, I can confirm that glob patterns are still not working on Windows. Maybe it's an idea to use https://code.visualstudio.com/docs/extensionAPI/vscode-api#RelativePattern instead of resolve? I'm not sure if it will fix things...
Update: upon further research, I'm positive that changing:
Line 20 in 212e7fd
const globPath = new RelativePattern(workspace.workspaceFolders[0], NodeTDD.getConfig<string>(config.GLOB))
should do the trick, because path.resolve()
will never result in more than one folder on Windows. Also, since the glob pattern uses /
, path.posix.resolve()
would be needed, but would still give you a single folder.
from node-tdd.
@prashaantt Please see the referenced PR. I have tested this on Windows only with a deep tree and the default glob setting, and it works like a charm.
from node-tdd.
Related Issues (20)
- Parse nyc output HOT 5
- Stuck in building... HOT 45
- Support custom scripts instead just npm tasks HOT 4
- Terminal output setting HOT 2
- No an issue (Need some help to setup converage) HOT 8
- Clicking should show you the current build progress, not cancel the build. HOT 4
- If you save with the test results panel open, a new build should not start HOT 1
- Installed but not showing in VS Code anymore HOT 2
- TDD is not working on my windows machine HOT 1
- Does this work with AVA? HOT 1
- Add option to explode spectacularly but succeed silently HOT 4
- Issue Running on Windows 10 HOT 2
- StatusBarItem priorities are off
- node-tss launches multiple node processes that never close
- package.json was not found
- TDD misconception HOT 1
- Results shown in output are not displayed correctly HOT 1
- Not displaying the tests passed and % coverage HOT 2
- Support for running bash command/docker command
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-tdd.