prakhar1989 / progress-cpp

A flexible ASCII progress-bar for C++

Hello 👋

I'm Prakhar, a software engineer working on Firebase at Google! I live in San Francisco and love building awesome tools for developers. To know more about me visit my website.

Thanks for stopping by!

progress-cpp's Issues

Using the library slows down my code execution extremely

Right now I'm working on a ray tracer and I thought it would be a nice touch to add in a progress bar on the command line. This looked simple enough so I grabbed. But after putting in, it's use drastically slowed down the render times. For example, I'm trying to render a 960x540 image (and about 10 samples per pixel).

• If I don't use this library, on average it takes about 3.3 seconds on average to do a render.
• If have the ticks set to the height of my render (e.g. ProgressBar(540, ...)) and incremented it after completing a row of pixels, it took on average it took 3.8 seconds to complete a render
• If I have the ticks set to count all of the pixels of my render (e.g. ProgressBar(960 * 540, ...)) and increment after completing a single pixel, it took an average of 21 seconds (!!)

After taking a look in the display() code, I think the cause is all of the IO to standard output. There should be some better way to build the string that needs to be printed. I.e. buffer the output string. I can try to provide a solution to this if you'd like me to, but it might be a bit before I get around to it.

what about ship it with a c++ pakage manager?

Hello,
this is actually not an issue, just a suggestion.
what about ship it with a c++ pakage manager, like for example conan?

Cheers.

incorrect comments in example

Great header lib. The comments in your example do not line up to the actual functionality.

Not possible to nest multiple progressbars

Hey,
I tried nesting multiple progressbars like in this example:

#include <iostream>
#include "progressbar.hpp"

int main()
{
    ProgressBar pb1(100, 70);
    for (int i = 0; i < 100; ++i) {
        pb1.display();
        ++pb1;
        // Do additional stuff
        ProgressBar pb2(100, 70);
        for (int j = 0; j < 100; ++j) {
            pb2.display();
            ++pb2;
            // Do additional stuff
        }
        pb2.done();
    }
    pb1.done();
    return 0;
}

Unfortunately, this does not work. Instead the first progressbar disappears as soon as the second one gets displayed for the first time. After the second bar is finished, the first bar appears only for a brief moment, updates once, and disappears again.
Is there a way to nest two progressbars using the current implementation?
PS: If you want to run the example code, I recommend putting some sleep()/uslepp() in there, otherwise it will run too fast to notice.