"missing ( before formal parameters" js error about django-ajax-selects

[GoogleCodeExporter]

I asked the original submitter about it and he didn't get back to me.  sorry 
also for the delay on my end.  your 
patch is gratefully accepted and committed now.

Original comment by [email protected] on 4 Jul 2009 at 7:44

• Changed state: Fixed

[GoogleCodeExporter]

No, you are mistaken about:

bq. removing the mysterious filter on the id {{html_id|cut:"-" }}  
autocomplete.html
was submitted by somebody else and I think that was a project specific thing for
him.

This is very important thing especially for admin part, where several id for 
input
fields can be with "-" symbol, for example inside inline forms. In this case 
anyone
will get js error: "missing ( before formal parameters". I think this filter
(cut:"-") must be in all templates, as I did in my patch.

Original comment by [email protected] on 4 Jul 2009 at 11:17

[GoogleCodeExporter]

I'm sorry, I didn't look through this and understand the original issue 
completely.  You are correct.  Fix now 
committed for all 3 templates. thank you !

Original comment by [email protected] on 5 Jul 2009 at 11:01

[GoogleCodeExporter]

No, I think you are mistaken again.

You don't need to apply this filter to every {{ html_id }}, especially inside 
<input
id="">. You need to do this only for javascript function's names.

It will be better if you merge my patch with 10 revision (if i'm not mistaken 
about
number). It is simpliest and safe method

Original comment by [email protected] on 6 Jul 2009 at 8:51

[GoogleCodeExporter]

correct number - 9 revision

Original comment by [email protected] on 6 Jul 2009 at 9:17

[GoogleCodeExporter]

ok, check it now please.

Original comment by [email protected] on 6 Jul 2009 at 9:52

[GoogleCodeExporter]

Thanks! Everythings is ok!

Original comment by [email protected] on 6 Jul 2009 at 1:55

[GoogleCodeExporter]

ah but, thank you ramu... !

Original comment by [email protected] on 6 Jul 2009 at 2:23

• Changed state: Verified