Comments (28)
okay thanks!
from kitabe.
Sorry by mistake closed the issue๐ถ
from kitabe.
It will be fine with v3.9.2
from kitabe.
@Praful932 can I dm you the SS on discord, the env is not getting activated
from kitabe.
I would like to apologize for the delay (due to exams), but work is in progress๐
I made some changes, and the carousel now works something like this (shown in video)
https://www.loom.com/share/3ddc356773a14b73a5aa8e4de8c2ea50
I was not able to figure out how I can move the carousel forward by 1 block (Since Bootstrap doesn't provide a multi-image sliding option), so decided on doing 3 blocks at a time.
I am presently working on the carousel for the mobile view. But I realised since the text is in the picture if I reduce the height (for small screens), the text won't be visible to us. Presently looks like this with block-sized pictures:
https://www.loom.com/share/87d9979b88944854a38eb94faea7264e
(Pls ignore the positioning of controls, WIP๐
)
@maneprajakta
from kitabe.
@Greeshma2903 No issues.
It's ok if you go by 3 blocks at a time.
Yep seems fine to me ๐ฏ
from kitabe.
@Greeshma2903 No problem.
Also it's alright to open a WIP PR, and push commits so we can also track the progress :)
from kitabe.
Hi @Greeshma2903 Thanks for your interest in the project :)
Expected to show me a list of similar Genres.
Could you elaborate this?
In the mockup could you add how it would look when scaled to a mobile view? particulary the 1st one
For the 1st one it would be nice to have a one block auto scroll
As for the color scheme theres an ongoing issue #48
Check this out @maneprajakta
from kitabe.
@Greeshma2903 From the mockup what I could see is that instead of having four carousels in the genre section it should be replaced by a single carousel seems great to me.
Yes, think for mobile view also.
from kitabe.
Thank you assigning this to me๐!
Yes sure, I'll draft the interface for small screens and get back to you.
Regarding the expected behavior:
I expected each carousel block to show me a list of similar genres, which it did not. And moreover the genres where more than 3 (as indicated), which might confuse the user.
@Praful932 sir, I am sorry but I couldn't understand, the 1st one means the first carousel block right?
from kitabe.
@Greeshma2903 From the mockup what I could see is that instead of having four carousels in the genre section it should be replaced by a single carousel seems great to me.
Yes, think for mobile view also.
Yes ma'am, working on it๐
from kitabe.
@Greeshma2903 not sure about what you meant by similar genres
First one as in this one
Just call me @Praful932 without any honorifics ๐ This is Open source
from kitabe.
Um, actually I thought there were multiple carousels, so each carousel might be a group of similar genres (like fiction and its sub-genres). But that wasn't the case ๐ .
@Praful932 @maneprajakta I have made 2 different prototypes for small screens. Pls check them and would love some feedback on the same. https://www.figma.com/file/quY3GKiD5RgWhsJAg2PKyE/Carousel-draft-Kitaabe?node-id=0%3A1
@Praful932 Okay so I'll implement auto-scroll for the 1st one. But regarding this, on one scroll, should I let it move forward by 1 block/ all 4 blocks?
from kitabe.
@Greeshma2903 yep it's not like that ๐
we had arranged alphabetically in groups.
All three designs are Great ๐ซ but carousel each with 3 blocks seems perfect to me.
from kitabe.
@Greeshma2903 yep it's not like that ๐ we had arranged alphabetically in groups.
All three designs are Great ๐ซ but carousel each with 3 blocks seems perfect to me.
Oh ๐
thank you! @maneprajakta I have enabled editing for you if you want to make particular changes in UI. should I now clone the project and start with the code part? OR should I start after you make the changes?
Also, the version of Bootstrap used is v4.0, right?
from kitabe.
@Greeshma2903 No changes from my side you can start working on it.
Yes, Bootstrap 4 is used.
Go through Starter Guide once it will help you in setting up the project.
from kitabe.
Um, actually I thought there were multiple carousels, so each carousel might be a group of similar genres (like fiction and its sub-genres). But that wasn't the case ๐ .
@Praful932 @maneprajakta I have made 2 different prototypes for small screens. Pls check them and would love some feedback on the same. https://www.figma.com/file/quY3GKiD5RgWhsJAg2PKyE/Carousel-draft-Kitaabe?node-id=0%3A1
@Praful932 Okay so I'll implement auto-scroll for the 1st one. But regarding this, on one scroll, should I let it move forward by 1 block/ all 4 blocks?
Mobile view seems good to me. Let it move forward by 1 block You can start working on it :)
Happy hacking!
from kitabe.
Great!
@maneprajakta I had a query regarding the steps after cloning! Since I am contributing only to the frontend part, do I still need to install virtualenv? can I just create a new branch and start fixing the issue?
from kitabe.
@Greeshma2903
Yes as you need to view the changes you made locally right. If you don't set up a project like installing everything from requirements.txt the project won't run. You will not be able to view the changes done.
from kitabe.
Hey, when I tried installing virtualenv, it shows:
bash: pip: command not found
Do I need to download python env first?
Sorry for disturbing again, but I am new to the setup and python๐
from kitabe.
@Greeshma2903 Have you installed pip ?
Also what OS you are using.
No issues :)
from kitabe.
@Greeshma2903 Have you installed pip ?
Also what OS you are using.
No issues :)
Windows
Nope, didn't know about pip, will do so
from kitabe.
@Greeshma2903 Have you installed pip ?
Also what OS you are using.
No issues :)Windows
Nope, didn't know about pip, will do so
from kitabe.
I think python has not come pre-installed on my OS. I was checking a guide to install it and realized that different versions of python have different requirements. Which one will I require for this project? Python 2.7 OR 3.9?
from kitabe.
Yep, in windows, it doesn't come pre-installed. Go with the latest version of python.
from kitabe.
The Project works seamlessly on Python version 3.8.6
from kitabe.
Thanks! So I'll download the v3.8.6? Or will it be fine with v3.9.2?
from kitabe.
@Greeshma2903 any updates?
from kitabe.
Related Issues (20)
- Enhancing features of home and explore page HOT 5
- Navbar(sticky) HOT 1
- Improper positioning HOT 4
- QA : Add formatter and linter HOT 2
- Different heights of button HOT 1
- Adding custom scrollbar in firefox HOT 6
- Redesign login text box for better user experience HOT 4
- After refereshing the info remains HOT 1
- Incorrect display in a range HOT 1
- Download database for user rating directly from Django admin as csv file HOT 1
- The Navbar is disturbed in small screen sizes HOT 3
- Hovering effect on More Details button in explore section. HOT 8
- Blinking Cursor Coincides With Search Icon In Nav Search HOT 5
- To create a fixed top navbar. HOT 1
- Recommendations based on what the user views HOT 1
- Recommendations not being displayed while searching a book HOT 3
- Deployment alternative to heroku ๐
- Move dependency management to poetry
- Add Pre-commit hooks
- Search bar is not working and summary is not showing HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kitabe.