Coder Social home page Coder Social logo

New Feature : Wishlist about kitabe HOT 36 CLOSED

praful932 avatar praful932 commented on June 7, 2024
New Feature : Wishlist

from kitabe.

Comments (36)

maneprajakta avatar maneprajakta commented on June 7, 2024 1

Hi, @Mirnalin I have edited your feature request description please follow it accordingly and make changes to it.
Also while creating an issue please follow the Issue template.
Go through our Starter Guide 😃 it will help you in getting started with project .

from kitabe.

SalmaZakaria avatar SalmaZakaria commented on June 7, 2024 1

@Praful932 @maneprajakta I am very sorry for the late reply
I am working on it now

from kitabe.

Praful932 avatar Praful932 commented on June 7, 2024 1

Just Book modal should be fine for now

from kitabe.

Fairspy avatar Fairspy commented on June 7, 2024 1

@maneprajakta I am basically done will open a PR by today or for sure tomorrow.

from kitabe.

Miru-s avatar Miru-s commented on June 7, 2024

@maneprajakta Hey! I have edited the comment and elaborated this issue and also let know if you want any more changes to it. I will like to solve this issue. Please assign this to me. And add GsSOC'21 label.

from kitabe.

maneprajakta avatar maneprajakta commented on June 7, 2024

@Mirnalin have you thought about how you will be implementing this, can you elaborate?

from kitabe.

maneprajakta avatar maneprajakta commented on June 7, 2024

@Mirnalin any updates ?

from kitabe.

anjali494 avatar anjali494 commented on June 7, 2024

@maneprajakta I am a GSSOC'21 participant and i would like to work on this feature. Can you please assign this to me?
I plan to do the following to implement this feature:

  1. add a wishlist button on the header
  2. add a 'add to wishlist' button on the dialogue box that appears after clicking on 'More Details'.

from kitabe.

Miru-s avatar Miru-s commented on June 7, 2024

@maneprajakta I'll be adding a save for later button along with "more details" and "rate this book" buttons.
Along with it I'll add a wishlist button (to check out the list of saved books) in the header.

from kitabe.

Praful932 avatar Praful932 commented on June 7, 2024

@Mirnalin wouldn't the intention/functionality of save for later & wishlist button almost be the same?

from kitabe.

Miru-s avatar Miru-s commented on June 7, 2024

yep, i was just using the two phrases for the same thing @Praful932

from kitabe.

Praful932 avatar Praful932 commented on June 7, 2024

Alright, we can have a wishlist button button in the modal that comes up from search, It would be nice if you could make a mockup of the modal UI that you wish to make, you'll also have to make necessary modal connected with user in backend and also a separate page for the same
@maneprajakta what do you think should we keep a separate page for this or put it into Library which is being created by #64
then we should make a new issue for the page after that issue is finished

from kitabe.

maneprajakta avatar maneprajakta commented on June 7, 2024

@Praful932 separate page would be better as #64 is for books which are rated by the user but wishlist is something which user wants to read.

from kitabe.

Fairspy avatar Fairspy commented on June 7, 2024

@Praful932 @maneprajakta I actually have a suggestion for this we could add two buttons below the library heading with read and saved for later and with javascript we can make it so that clicking on one would show that part of the html file as I was thinking having too many links on the header would make it feel crowded.

from kitabe.

Miru-s avatar Miru-s commented on June 7, 2024

@Praful932 @maneprajakta so assign it to me as GSSoC'21 participant.

from kitabe.

Praful932 avatar Praful932 commented on June 7, 2024

Agree with @Fairspy You can add Read & Saved, and clicking on them, would lead to respective pages, @Mirnalin you can make it similar what is being done in #64

from kitabe.

maneprajakta avatar maneprajakta commented on June 7, 2024

@Mirnalin any updates?

from kitabe.

SalmaZakaria avatar SalmaZakaria commented on June 7, 2024

@Mirnalin Could you assign this issue to me, please?
I am GSSOC'21 Participant
1- I will add a wish icon on every book and A WishList that contains all the books pressed by the user

from kitabe.

maneprajakta avatar maneprajakta commented on June 7, 2024

@SalmaZakaria you can go ahead with this . Before that, if you could explain how you aim to do this?

from kitabe.

Miru-s avatar Miru-s commented on June 7, 2024

@maneprajakta i'm working on it, it will take a while

from kitabe.

Praful932 avatar Praful932 commented on June 7, 2024

@Mirnalin any updates?

@Mirnalin Since there was no response so we had to unassign you
@SalmaZakaria There's an ongoing feature #100 , and we would like it to all come under library, clicking on library will have two options already read books & wishlist, and clicking on any of them will redirect to that page.
You can elaborate your implementation details so we know you're on the same page

from kitabe.

Miru-s avatar Miru-s commented on June 7, 2024

@Praful932 sorry actually due to some mishappening in the family I couldn't update.
I'm working on it, please assign it to me again.

from kitabe.

Praful932 avatar Praful932 commented on June 7, 2024

@Praful932 sorry actually due to some mishappening in the family I couldn't update.
I'm working on it, please assign it to me again.

Sorry to hear that, Hope you're well. Due to the nature of open source, the issues are assigned on a FCFS basis, and since no one was assigned, the issue was up for grab. There are a lot of unassigned issues that you can take up. And we are happy to answer any doubts, you can open up a new discussion in the forum or connect with us on discord.
Thanks

from kitabe.

SalmaZakaria avatar SalmaZakaria commented on June 7, 2024

@Mirnalin How can I go ahead without assigning it to me?
Is this possible?

from kitabe.

SalmaZakaria avatar SalmaZakaria commented on June 7, 2024

@Praful932 I will add a page with Cards containers wished books only and I haven't found this on issue #100
So Can you assign this to me to start implementing it?

from kitabe.

Praful932 avatar Praful932 commented on June 7, 2024

Assigned you @SalmaZakaria
You can implement a similar page as #100 , and link in dropdown when Library is clicked, one would be Wishlist and another would be Your books. Check the PR associated with that issue for more details

from kitabe.

SalmaZakaria avatar SalmaZakaria commented on June 7, 2024

@Praful932 After I had cloned the repository to my local machine I don't know how to see my changes when I click on any HTML page it opens with Html only without CSS

from kitabe.

Praful932 avatar Praful932 commented on June 7, 2024

@SalmaZakaria Head to project discord

from kitabe.

Praful932 avatar Praful932 commented on June 7, 2024

@SalmaZakaria Any updates? You can open a WIP/Draft PR so we can track that you are going in the right direction :)

from kitabe.

maneprajakta avatar maneprajakta commented on June 7, 2024

@SalmaZakaria any updates?

from kitabe.

maneprajakta avatar maneprajakta commented on June 7, 2024

@SalmaZakaria you can draft a wip pr for changes done till now

from kitabe.

Praful932 avatar Praful932 commented on June 7, 2024

@SalmaZakaria Any updates?

from kitabe.

Fairspy avatar Fairspy commented on June 7, 2024

@Praful932 @maneprajakta Can I work on this?

from kitabe.

maneprajakta avatar maneprajakta commented on June 7, 2024

@Fairspy Yes go for it.

from kitabe.

Fairspy avatar Fairspy commented on June 7, 2024

Great then I'll start working on it!
@maneprajakta I would just like to ask one thing do you guys want the save for later button on the book card or in the book modal?

from kitabe.

maneprajakta avatar maneprajakta commented on June 7, 2024

@Fairspy any updates?

from kitabe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.