ArchiveReader needs proper IDisposable implementation about osu

[jordhan94]

https://msdn.microsoft.com/es-es/library/system.idisposable(v=vs.110).aspx

    // Flag: Has Dispose already been called?
    bool disposed = false;
    // Instantiate a SafeHandle instance.
    SafeHandle handle = new SafeFileHandle(IntPtr.Zero, true);

    // Public implementation of Dispose pattern callable by consumers.
    public void Dispose()
    {
        Dispose(true);
        GC.SuppressFinalize(this);
    }

    // Protected implementation of Dispose pattern.
    protected virtual void Dispose(bool disposing)
    {
        if (disposed)
            return;

        if (disposing)
        {
            handle.Dispose();
            // Free any other managed objects here.
            readers.Clear();
        }

        // Free any unmanaged objects here.

        disposed = true;
    }

[peppy]

visual studio inserts a more concise version for you, for what it's worth.

[jordhan94]

do you think is really necesary to implement the 'IDisposable' when the class has only 1 attribute?

[ddevault]

What else are you expecting it to dispose of?

[peppy]

when that one reference is holding open file streams? yes.

[ddevault]

The streams are disposed of...

[peppy]

requires further investigation. was getting piling up open file handles on quick testing.

[ddevault]

It does allocate file streams to consumers, and those consumers are responsible for closing them. But that's the right design IMO, otherwise we'll get use-after-frees.

[peppy]

okay, will add finalizer to WorkingBeatmap and call it a day then.