Coder Social home page Coder Social logo

Comments (3)

glenpike avatar glenpike commented on June 12, 2024 1

Okay, it probably makes sense to "play safe" by default. As this would be a breaking change, I will probably slate it for later - if we are to release non-breaking changes soon.

from backbone-forms.

glenpike avatar glenpike commented on June 12, 2024

Half inclined to ignore this because you're fiddle is written in CoffeeScript and I have to learn something else just to grok the problem... :p

There is a workaround - you can supply your own itemToString function as part of the schema if it's possible that you need to escape data.

I will also mention in the documents.

I've done a JavaScript JSFiddle of the workaround ;)

from backbone-forms.

wesvetter avatar wesvetter commented on June 12, 2024

If you're displaying any user-submitted data, I'd advocate overriding it at the top level with the safe (escaped) version, and passing an unescaped version at the schema-level should you need an unescaped itemToString.

In other words:

// main.js
window.Backbone.Form.editors.List.Modal.prototype.itemToString =
 function() {
   ... // escaped version
}

// foo.js
new Backbone.Form({
  schema: {
    itemToString: function() { ... } // unescaped version
  }
})

It's worth noting that if you want markup in your itemToString method you still need to remember to escape user-submitted values. e.g.:

itemToString: function(value) { return key + ": <strong>" + _.escape(value) + "</strong>" })

I'd also consider using _.escape rather than $('div').html(value).text().

from backbone-forms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.