Notes play as you enter them. about powertabeditor

[cameronwhite]

I'll bump up the priority for this

[jcelerier]

that would be a great feature indeed, any hope to get it ?

[jcelerier]

if you guide me a bit through the source code I'd be interested in looking into it :-)

[cameronwhite]

Sure, that would be great!
The key presses are handled at

powertabeditor/source/app/powertabeditor.cpp

Line 1878 in 97b66d3

bool PowerTabEditor::eventFilter(QObject *object, QEvent *event)

The normal MIDI playback is handled in a background thread through https://github.com/powertab/powertabeditor/blob/master/source/audio/midiplayer.cpp . I don't know if this functionality should necessarily go in there, but it might be a good starting point for a similar background thread that the app can send events to when notes are entered.

Feel free to ask if you have any more questions, or set up a draft pull request, etc!

[jcelerier]

The normal MIDI playback is handled in a background thread through https://github.com/powertab/powertabeditor/blob/master/source/audio/midiplayer.cpp . I don't know if this functionality should necessarily go in there, but it might be a good starting point for a similar background thread that the app can send events to when notes are entered.

wouldn't a good way be to have an event queue from the ui thread to the background midi thread sending "unattended" midi events to be played ?

[cameronwhite]

That sounds very reasonable, it would just need a few changes to keep the thread alive (currently a new one is spawned when playback starts) and handle different events in the background thread.

[Ebdim9th]

This is just what I was looking for. What's particularly interesting was I was playing back a GP3 file of an Animetal song and it got to an exaggerated whammy bar part and Power Tab's MIDI played it back perfectly even though it doesnt currently have that function in the tab symbols/effects drop down menu