Coder Social home page Coder Social logo

Comments (8)

tysonjhayes avatar tysonjhayes commented on August 21, 2024

At first blush my only gripe is that you don't use verb-noun formatting for your private functions. Otherwise it looks pretty good to me, though I'll need a bit more time to dive into the specific chunks of it.

from dscresources.

SimonWahlin avatar SimonWahlin commented on August 21, 2024

Oh, I'm sory, I'll fix that.

Since a lot of other resources do the same, I got the impression that this was an accepted and easy way to recognize private functions.

from dscresources.

tysonjhayes avatar tysonjhayes commented on August 21, 2024

@SimonWahlin It's a personal pet peeve of mine, most of the time the export module doesn't get specified so you'll get a warning about non-verb-noun functions which just annoys me. 😀

from dscresources.

SimonWahlin avatar SimonWahlin commented on August 21, 2024

@tysonjhayes That is a good point. The private functions has been renamed and I also added a little more test coverage.

from dscresources.

SimonWahlin avatar SimonWahlin commented on August 21, 2024

Thanks @KarolKaczmarek !

Unforturnately I get an error stating that I do not have Admin rights to 'PowerShell' organization.
ref: https://help.github.com/articles/transferring-a-repository/#transferring-from-a-user-to-an-organization

How do we go about that?

from dscresources.

KarolKaczmarek avatar KarolKaczmarek commented on August 21, 2024

Can you drop me an email please?
Thanks

from dscresources.

kwirkykat avatar kwirkykat commented on August 21, 2024

@KarolKaczmarek What's happening with this?

from dscresources.

kwirkykat avatar kwirkykat commented on August 21, 2024

Talked with @KarolKaczmarek offline. This has already been added directly to PSGallery here.

from dscresources.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.