Comments (10)
I realize there isn't much logic but I'd still like to see some pester tests, even if it just runs Test-xDSCResource and Test-xDSCSchema just to validate that any future changes have some kind of baseline to run against.
from dscresources.
That sounds like a reasonable plan. I have added a verbose transcript of test-xdscresource, test-xdscschema, and invoke-pester. Metadata removed. Long term these three should merge. I am willing to work on it, when time allows.
https://github.com/mgreenegit/xDefender/blob/master/test_transcript_verbose.txt
from dscresources.
I should also note that I would expect the transcript file to be removed after transfer.
from dscresources.
😆 I guess that is what I asked for. I meant add the tests to your repro so anyone can run it every time.
I meant more something like this:
https://github.com/PowerShell/xWebAdministration/blob/dev/Tests/MSFT_xWebsite.Tests.ps1
from dscresources.
I agree with you. I think the best option is to add those checks to the dscResource.tests script, so all resources are evaluated by the build service.
https://github.com/powerShell/dscResource.tests
from dscresources.
Yup, already have an issue filed to run most of what I've pointed out. PowerShell/DscResource.Tests#3
from dscresources.
The ReadMe file for this module has been updated to match the new template. Confirm whether it is acceptable to transfer?
from dscresources.
Thank you for transferring this!
Overall it looks good, just a couple comments:
- This module contains single resource, but in readme release notes, I see:
0.1.0.0
Initial release with the following resources:
<and here list all properties of that resource>
we should just list a single resource there, not properties.
- Can you clean up the commented out code? e.g.
# Get-TargetResource -Name DefenderPreferences -HighThreatDefaultAction Quarantine
If that's supposed to act as example of calls for each function, please move it to .EXAMPLE section in comment above that function
<#
.SYNOPSIS <description>
.PARAM
parameter_name <description of parameter>
.EXAMPLE
<example>
#>
- Also, there are single letter variable names in quite a few places like $k or $v.
I'd recommend using verbose names for ease of understanding (https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md).
If you'd have few minutes to correct that, that's great, but if not I don't consider it blocking and we can refactor it later.
from dscresources.
I have resolved everything except the example text. I want to discuss that change before we commit to it. Transfer complete. Thanks.
from dscresources.
It's in: github.com/powershell/xdefender/
from dscresources.
Related Issues (20)
- RFC - DSC Community Logo HOT 10
- DSC Resource Kit modules should use Semantic Versioning HOT 13
- Operator usage style guideline HOT 3
- Confirm Behavior of Puppet/Chef using DSC Resources with Get missing MOF parameters HOT 3
- Correct Markdown Rule Violations in README.MD
- Correct Markdown Rule Violations in CONTRIBUTING.MD
- Change Gitter Icon to refer to the PowerShell Slack Channel instead
- The Resource Modules links in DSCResources and xDSCResources are not pointing to the latest versions
- Update Docs Documentation on PendingReboot Migration
- Add Guideline for Adding Resources to DSCResourcesToExport in Manifest
- Powershell DSC does not work HOT 7
- IIS migration
- DscResources/CONTRIBUTING.md: Test Templates-link is stale HOT 1
- Partial Configurations
- DSC resource Update-Help
- xAdUser: Requesting to manage ExtensionAttributes[1-15] / Extended schema attributes HOT 1
- Opened Wiki HOT 8
- DscResources: Website Link for Repository Is Broken
- DSCCore HOT 1
- Multiple guidelines HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dscresources.