poteto / ember-lazy-video

Lazy load videos in an Ember app

ember-lazy-video's Issues

Releasing a new version of the addon.

Hi, in the current version of the repo the #31 and #23 are solved and in addition the capacity of adding custom poster/thumbnail to the videos, are you planning on publishing a new version to NPM with these changes or is something more that you want to tackle on before releasing a new version?

If this is the case let me know if there's anything I could do to help.

Thanks!

After a certain width youtube thumbnail doesn't fill

Granted this is a large width but the Vimeo thumbnail continues to properly fill the space, the Youtube one does not. See attached below

Full urls vs Provider + ID

This is more of a question at this point.

In past plugins I've used (like this one) that have exposed embed functionality for a number of providers like this addon does, I could just pass in the full url to the video and the plugin would sort out which provider it was from and return the appropriate embed. So for this this addon instead of:

{{lazy-video provider="youtube" videoId="gvdf5n-zI14"}}

it would be:

{{lazy-video video="https://vimeo.com/108532122"}}

I think this makes it easier from the end user's perspective since they don't have to worry about breaking out the provider and the videoId.

Thoughts? I can help with implementation if there is interest.

Gracefully handle API errors when retrieving thumbnails

For example, we could show a user-specified default placeholder in its place.

Allow registration of local providers

Implement something like Torii's provider registration, so anyone can add their own providers locally within their app

Build proper github page example for the addon

Themes for default 'play' button

add ci

Add Liveleak to built-in providers

All provider endpoints should return promises

Issues in Ember 1.11

I'm getting the following deprecation warning when using this component in Ember 1.11

WARNING: Binding style attributes may introduce cross-site scripting vulnerabilities; please ensure that values being bound are properly escaped. For more information, including how to disable this warning, see http://emberjs.com/deprecations/v1.x/#toc_warning-when-binding-style-attributes.

Also, in 1.11, {{bind-attr ...}} is deprecated so you may want to update that in the component template (or wait until bind-attr is completed removed).

Update to ember-cli 0.1.5

Thumbnails are broken

Thumbnail images don't appear at all in the current version. I suspect it is partially related to this change, although if I revert to just background instead of background-image the formatting is still not correct. Here is a before and after of what I'm talking about:

Feature Request: Configuration for protocol relative URLs

Hey everyone, first - thanks for the addon! I was wondering if there was any interest in adding a configuration option for specifying a protocol for URLs, rather than using the default protocol relative ones. In our mobile app, these end up being file:// which, of course, don't work. I would be happy to work on this PR if that sounds interesting.

Add twitch.tv to built-in providers

Stylesheet is not imported

Branching from #6, the stylesheet at app\styles\lazy-load.css does not get imported when this addon is installed in a project

Add Dailymotion to built-in providers

Youtube apiUrl() is not necessary?

I don't see this function being used anywhere, can it be removed?

Update to ember-cli 0.1.7