Comments (8)
@VibhorCodecianGupta You should request for a review under your pull request and not here. 😬
from postman-code-generators.
i was going through the code base in lib directory i find an import of a file that does not exist.
postman-code-generators/lib
languageMap = require('./assets/languages.js');
there is no languages.js inside asssets. How this works?
from postman-code-generators.
Please run 'node npm/pre-package.js' to get the file languages.js
languages.js
is a file that is not committed to the repository but it is created using the above script. It is required to run the functions in lib
folder and this file is added to the package before the postman-code-generators module is published.
from postman-code-generators.
@shreys7 @umeshp7
I would love to work on this issue, please assign it to me. 😃
from postman-code-generators.
@shreys7, @umeshp7 what parts exactly require the exception handling? I see that there are 3 methods and the callback
methods are mostly being passed the error.
Do you wish to replace most of the if statements with try-catch blocks?
from postman-code-generators.
https://www.joyent.com/node-js/production/design/errors
Found this link useful to refer to @shreys7 @umeshp7
Added try catch block in index functions, the link above suggests using error handling methods like throw/catch with synchronous functions for capturing operational errors, which is why I did not replace the callback flow.
Does this issue need adding try/catch to index of separate codegens as well? Will do that if required
from postman-code-generators.
@kolharsam Thanks for the interest.
You are right most of the places if blocks are handling some of the known errors. And no we don't want to simply replace those with try-catch.
Identify places where there could be unexpected exceptions.
For instance: Simply putting contents of the entire getLanguageList function in try
, and in the catch
block you could console the error and return an empty object.
from postman-code-generators.
@umeshp7 another attempt at #204
from postman-code-generators.
Related Issues (20)
- Add support for acv.addFormats
- Code generator library written in dart.
- VBA: Codegen feature for VBA
- Power Query: Codegen support for excel power query.
- cURL is missing methods HOT 1
- unused `fs` import on `NodeJS - Native` Code
- Suggest: changing the package go ioutil was deprecated support <1.16 to new native package io. HOT 2
- Laravel Http Code Snippet Generator HOT 1
- golang : ioutil.ReadAll is deprecated from Go 1.16 HOT 2
- Scala+sttp code snippet generator
- The version of the postman-collection dependency of HTTP-related codegens is too early
- Add python urllib3 support
- Enhance CURL Code generation options
- Why using headers when it is not required in C-libcurl?
- [Security] semver (dependency) vulnerable to Regular Expression Denial of Service
- python.http-client generates code snippet not workable for http protocol
- Delphi Pascal code generator feature HOT 1
- code-snippets generator for M language (microsoft power query)
- Invalid production flags for pnpm
- Failed to run yarn install on codegen csharp-httpclient HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from postman-code-generators.