Coder Social home page Coder Social logo

Comments (16)

Scrum avatar Scrum commented on July 30, 2024 1

Thanks, I will investigate this.

from gulp-posthtml.

michael-ciniawsky avatar michael-ciniawsky commented on July 30, 2024

@revelt This one is my nemesis atm :) Jesus Christ..., there is something buggy in general 'somewhere', could you post your Gulp Config please and log the options {Object} out? (Otherwise please provide a test repo so I can do it myself 😛)

from gulp-posthtml.

Scrum avatar Scrum commented on July 30, 2024

@revelt Hi, this PR must closed this bug.

from gulp-posthtml.

revelt avatar revelt commented on July 30, 2024

@gitscrum but it's not merged in yet, isn't it? should I wait until it's merged to 100% confirm?

from gulp-posthtml.

Scrum avatar Scrum commented on July 30, 2024

@revelt yep.

from gulp-posthtml.

revelt avatar revelt commented on July 30, 2024

OK. If you guys see it's working feel free to close yourselves. I got fed up with this months ago and stopped using PostHTML completely. On the positive side, it made me produce quite few libs on npm.

from gulp-posthtml.

Scrum avatar Scrum commented on July 30, 2024

@revelt try

from gulp-posthtml.

revelt avatar revelt commented on July 30, 2024

OK, I set it up again, no luck. Same as before, all slashes are still removed from all img tags.

plugins

slashes

I'm using { closingSingleTag: 'slash' } as options object. Maybe it's available only in posthtml-render where I took it from?

from gulp-posthtml.

revelt avatar revelt commented on July 30, 2024

By the way I can't fulfil @michael-ciniawsky request and share Gulp settings since it's closed source.

I mean, if anybody's using gulp-posthtml, just try flipping your own Gulp plugin settings, to export singleton HTML tags with and then without the closing slashes. See what happens, see if you can get it working. Because I can't :(

var options = { closingSingleTag: 'slash' }

from gulp-posthtml.

Scrum avatar Scrum commented on July 30, 2024

@revelt i work on this, don't worry.

from gulp-posthtml.

Scrum avatar Scrum commented on July 30, 2024

@revelt Hi, i create demo and this work for me.
Show me you case.

from gulp-posthtml.

revelt avatar revelt commented on July 30, 2024

The test is missing plugins, that's where the trouble happens. I'll fork and supplement the demo with a plugin and some CSS via PR. Is that all right?

from gulp-posthtml.

Scrum avatar Scrum commented on July 30, 2024

Yep.

from gulp-posthtml.

revelt avatar revelt commented on July 30, 2024

Done. Thanks for looking into this. The plugins seem the be "not seeing" the config, img is rendered without a slash in both cases after plugin processes the HTML.

from gulp-posthtml.

Scrum avatar Scrum commented on July 30, 2024

You lost actuar tree after call render.
I create PR which fixed this

from gulp-posthtml.

revelt avatar revelt commented on July 30, 2024

Aha! My bad. Thank you very much. Closing this.

from gulp-posthtml.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.