Comments (5)
clementnuss
commented on June 27, 2024
2
hi!
really sorry for the bug introduced while resolving #250 🤦🏼
I've now made the code simpler, with a proper early exit when bypassDNSResolution is true.
I've also added a testcase covering this issue.
can someone try the following image and report on whether the fix works on their side ?
docker.io/postfinance/kubelet-csr-approver:dns-check-fix
ghcr.io/postfinance/kubelet-csr-approver:dns-check-fix
from kubelet-csr-approver.
clementnuss
commented on June 27, 2024
2
release v1.2.1 with the fix is out.
sorry for the inconvenience, and hoping everything settles down 🙃
from kubelet-csr-approver.
kariya-mitsuru
commented on June 27, 2024
1
Thanks for the quick fix!
I checked it with helm chart 1.2.0 by setting image.tag to dns-check-fix, and it is approved without any problem!
from kubelet-csr-approver.
sherif-fanous
commented on June 27, 2024
Ran into the same issue now
from kubelet-csr-approver.
alan113696
commented on June 27, 2024
Same
from kubelet-csr-approver.
Related Issues (20)
- Feature request: option to bypass or tune SAN validation HOT 6
- Denies when hostname is not the dns name HOT 2
- Omit deprecated node-role.kubernetes.io/master taint
- Error: chart "kubelet-csr-approver" matching 0.2.5 not found in kubelet-csr-approver index. HOT 1
- Consider alternate image registry to Docker Hub HOT 3
- [Feature] NetworkPolicy in helm chart HOT 3
- Some certificates remain in the approved state but not approved,issued. HOT 3
- [helmchart] support artifacthub.io HOT 2
- Solve "The SAN DNS Name could not be resolved" without bypassDnsResolution HOT 7
- fix: invalid syntax in ServiceMonitor helm template HOT 4
- deploy/k8s/deployment.yaml wasn't updated HOT 2
- Node DNS name validation issue HOT 1
- Cannot run without --bypass-dns-resolution=true HOT 3
- Unable to retrieve the complete list of server APIs: certificates.k8s.io/v1 with default deployment HOT 2
- Consider adding support v1beta1 for backward compatibility HOT 2
- Feature: Add podLabels HOT 2
- Error: INSTALLATION FAILED: failed parsing --set data: error parsing index: strconv.Atoi: parsing "0-5": invalid syntax HOT 2
- Chart.yaml version, appVersion HOT 1
- Setting BypassDNSResolution also skips regex checks HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kubelet-csr-approver.