Coder Social home page Coder Social logo

Comments (4)

jeddy3 avatar jeddy3 commented on June 8, 2024

Sgtm.

from postcss-bem-linter.

simonsmith avatar simonsmith commented on June 8, 2024

Hey, with regard to the removal of:

The `:root` cannot be combined with other selectors.

Does such a rule for stylelint exist? Wanted to check before I look into adding it.

Also thinking about validating the custom property after the componentName to ensure it is camel case, as per this issue - suitcss/suit#91

It would cross over closely with the validation already perform by the bem-linter. Any thoughts on where that responsibility should lie?

from postcss-bem-linter.

davidtheclark avatar davidtheclark commented on June 8, 2024

selector-root-no-composition --- https://github.com/stylelint/stylelint/tree/master/src/rules/selector-root-no-composition

If camelcase custom property names is a SUIT convention that you want to enforce, I'd say we should build it into this module as part of the SUIT preset. We would also want to add a new option so the user could specify a patternf ro custom property validation.

from postcss-bem-linter.

simonsmith avatar simonsmith commented on June 8, 2024

Great, thanks

Still need to update the SUIT components and documentation. Will open an issue nearer the time.

from postcss-bem-linter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.