Comments (23)
I'd be in favor of a new release after the current issues are resolved. I wonder if it would be a good time to bump major release: since with the recent changes there's an API, having a major release number would be we could more meaningfully indicate with semver when that API has changed.
from postcss-bem-linter.
Before 1.0.0, the expectation is that minor version increases may break the API. I'd think I'd rather we stay at 0.x and iron out any kinks and instability before we're happy for 1.0.0. For example, going to 0.2 gives time for Twitter to use it for a few weeks and for any non-suit projects to try out the linter.
from postcss-bem-linter.
Ok, sounds good.
from postcss-bem-linter.
A bump to 0.3.0 would probably fit within semver though right? More meaningful error messages seem something worth releasing :)
from postcss-bem-linter.
Ah yes I meant 0.3.
from postcss-bem-linter.
π
from postcss-bem-linter.
@necolas If the pending pull requests work out, I don't have any other particular changes in mind, so would be eager for a new release.
from postcss-bem-linter.
let me test master out against our code base before i cut a new release. will do it this working week
from postcss-bem-linter.
i dropped HEAD into our codebase, introduced errors, and it failed to report them. so there is something not right with HEAD.
from postcss-bem-linter.
A 0.3 release for the latest namespace stuff would be great
from postcss-bem-linter.
sorry my comment suggested the opposite of what is happening. master doesn't report errors properly, which is why i haven't cut a new version
from postcss-bem-linter.
oh, huh ... errors are logging as PostCSS warnings (as discussed in #32 as #36), which means you'd need to be setup to see those (using postcss-log-warnings or something). do you have that in place?
from postcss-bem-linter.
the docs need to mention that, otherwise the plugin doesn't really do anything for you. so this plugin would be dependent on using 'postcss-log-warnings' too?
from postcss-bem-linter.
It depends on your workflow I guess. If you use webpack for example, you would prefer getting webpack warnings emitted. But yeah, your runner has to show you the messages.
from postcss-bem-linter.
I just added a sentence to Readme --- sorry I didn't know that it would just commit automatically without creating PR :)
Also, if it's really important not to rely on a runner or plugin to log the warnings, we could probably add an option to this plugin that will exit the process and print those warnings immediately.
from postcss-bem-linter.
We currently want the build to fail when the CSS is not properly scoped, otherwise it will end up in master.
The postcss logger plugin worked, but since we're using webpack I end up with 2 sets of warnings βΒ one from postcss, one from webpack. If I use throwError:true
, it exits with 1
but you can't tell why. It's not obvious that all the warnings printed before are actually the source of the error.
from postcss-bem-linter.
@necolas that why the runner need to emit errors via webpack (eg for eslint: https://github.com/MoOx/eslint-loader#errors-and-warning). This will need to be an option added in postcss-loader
from postcss-bem-linter.
I opened #44 to address this.
from postcss-bem-linter.
Another thing to discuss. master
produces warnings for selectors like:
.Button--modifier.Button--anotherModifier {}
We have some code like that in a new app. I think that pattern probably is something to avoid, because there are basically side-effects from including 2 modifiers together (should probably be a single modifier). Just wanted to check if there is any disagreement about that.
Thanks
from postcss-bem-linter.
Yeah, I agree that it would probably be better to use a single modifier.
from postcss-bem-linter.
@necolas Anything else you'd like to see done before a new release?
from postcss-bem-linter.
@necolas Any word on this?
from postcss-bem-linter.
tried master on our codebase; looked good. published as 0.3.0. thanks for all the great contributions.
from postcss-bem-linter.
Related Issues (20)
- Allow chaining BEM modifiers
- Please print expected selector in error message HOT 2
- Is there an online playground to try this to validate some BEM code? HOT 1
- Cannot get the plugin to log an error HOT 5
- Node#moveTo was deprecated. Use Container#append
- Add support for different types of components
- Issue with prepending selectors (separated by whitespace) HOT 10
- Clarify usage of initial vs combined HOT 2
- Does not work with Sass interpolation HOT 5
- How to configure it inside a postcss.config.js HOT 3
- Components not linted if no immediate rule HOT 2
- Implicit component file name customisation HOT 2
- valid component selectors detected as invalid, and reported line numbers are also incorrect. HOT 2
- Ability to have a themed component HOT 5
- Nested multiple definitions HOT 2
- Concise & verbose comment syntax for "weak" not fully working? HOT 1
- How check bem?
- Namespaces are confused as selectors
- Question: how to ignore not-pseudo class
- [4.0.0] `implicitComponents` in conjunction with a custom `componentName` pattern causes error HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from postcss-bem-linter.