[Feature Request] Copy text in goal notes with long press about greenstash

[starry-shivam]

I think adding an argument (showCopyButton) will be enough for this case. It's best to do the simplest method now, and change to more advanced later if there comes a use-case for that

Sure! works for me :)

On other note, check the available Icons and think the ContentCopy one is the right one.

Yeah looks good! We can go ahead with this.

You can check it out here: https://github.com/mrghosti3/GreenStash/tree/note-copy

Feel free to create a PR if you think it's ready. I'll review it tomorrow since it's late night where I am.

[mrghosti3]

Okay, will create a PR later. Have a great evening.

[mrghosti3]

Could implement this feature quickly. The previous ones are a bit more difficult for me as I'm new to kotlin overall, used to older way (Java and XML) of developing Android apps.

[starry-shivam]

Sounds like a good idea. I think adding a copy button here, which is visible after expanding, would be a better idea than long-press, as long-press can collide with the card's collapse UI which happens on single tap.

[mrghosti3]

How about adding a button on the left of the arrow? This could allow to skip needing to expand the note card.

[starry-shivam]

I don't think that would be great from a UX perspective because then it can only be an icon button, which would be very small and easily misclicked, leading to the expansion of the notes card instead of the text being copied. The other solution allows us to have an actual button with a decent size, which cannot be easily misinterpreted. I think something like (copyIcon "copy") using FilledTonalButton() would look much nicer.

[mrghosti3]

Understandable, then a copy button below text sounds like a good way to do. Gonna try and create it then.

ps. Also to clarify, it's a Filled tonal button with an icon or without?

[starry-shivam]

Great!

Also to clarify, it's a Filled tonal button with an icon or without

With, you can probably use something like Icons.Filled.Copy combined with ButtonDefaults.IconSpacing for placing icon and a text inside Row()

I think this could be implemented by preferably overloading or adding two additional parameters in ExpandableTextCard(), which is used to show notes. One is for deciding whether we should show a copy button (something like showCopyButton: Boolean), and the other is a callback (onCopyClicked(text)) which would allow us to handle copying of the text, this would allow us to implement the feature while also ensuring reusablility of common composables at the same time

[mrghosti3]

I think adding an argument (showCopyButton) will be enough for this case. It's best to do the simplest method now, and change to more advanced later if there comes a use-case for that.

On other note, check the available Icons and think the ContentCopy one is the right one.

You can check it out here: https://github.com/mrghosti3/GreenStash/tree/note-copy