Comments (41)
Hi Professor https://app.asana.com/0/16544941486330/16544941486330 I don't have the access to php panel or the MySQL database. Do you have the ER diagram for the database, would be helpful to implement in the database
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
http://130.211.240.130/phpmyadmin
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
I'm working on getting the designer view to come up for your user account.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Sounds great
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
I can't figure it out. Please use the root account for now but be careful not to change the schema. Here are the credentials:
username: root
password: Its7eK7dap8D
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Ok, thanks
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Now that the individual accounts are working correctly, I will change the root account password.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Over to https://app.asana.com/0/48844890659415/48844890659415. https://app.asana.com/0/48844890659415/48844890659415, please let me know if you have questions.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
https://app.asana.com/0/48844890659415/48844890659415, it may be best to first create a query that finds abstract classes that implement a single interface. These will be our candidates. I'll make this a sub task.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
So I could take look at the interface class
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Ah interesting. Does it pop up on google?
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
like oracle doc
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
also, I need a better understanding on the Skeletal Implementation. Let's discuss tomorrow.
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
https://app.asana.com/0/36107232964072/36107232964072 Do you understand the pattern now?
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Kind of, not deep enough
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Do you have any questions?
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
so we are checking the skeletal implementations, which is kind of if a class get extended from abstract class and if the abstract class implements interface. How this will be beneficial, what else is matter in this skeletal implementations. Do you have any other resource describing more about this pattern.
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Hi https://app.asana.com/0/36107232964072/36107232964072, just to follow up from our meeting yesterday, the skeletal implementor (or implementation, though, I think I would reserve that term for the individual methods that implement the interface methods) is the abstract class. Classes wishing to implement the interface would extend the abstract class (skeletal implementor) so that it would be easier to implement the interface. A great example of this is java.util.ArrayList. Notice, it is a concrete (i.e., non-abstract) class that implements the java.util.List interface but also extends the java.util.AbstractList abstract class. In this example, java.util.AbstractList is the skeletal implementor. Perhaps https://app.asana.com/0/39040660091509/39040660091509 can chime in if I am mistaken or to add more clarity.
https://app.asana.com/0/36107232964072/36107232964072, is this any clearer?
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Ah! Much clear. For now we are just looking upto abstract class and what interface that class extended?
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Right, because I feel that the interface they are extending is a hint as to whether it is a skeletal implementor. For example, implementing the Runnable interface as a skeletal implementor doesn't make a lot of sense because that interface is so general.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Attaching new list.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
https://app.asana.com/0/36107232964072/36107232964072, once https://app.asana.com/0/16544941486330/55599292395220 is complete, please use that column.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
https://app.asana.com/0/36107232964072/36107232964072, I've attached the spreadsheet to https://app.asana.com/0/16544941486330/55599292395220. Please use that sheet and let me know if you have any questions. Also, since I am late with this spreadsheet, we can change the due date.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Hi https://app.asana.com/0/36107232964072/36107232964072, any status updates here?
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
OK, I've adding the data in https://app.asana.com/0/48844890659415/48844890659415's repo to do the database.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
I also fixed a few compile-time errors in the subject repo.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
https://app.asana.com/0/36107232964072/36107232964072, I've created a table called confirmed_skeletal_implements in the database. Could you add the FQN of the confirmed classes following the skeletal implementation pattern here? I've also added a column in case a comment is to be made. As for whether we have the source, that's captured in the types table by the compilation unit being NULL. Please let me know if you have any questions.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Hi https://app.asana.com/0/36107232964072/36107232964072, any status updates here?
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
https://app.asana.com/0/36107232964072/36107232964072 Is this okay to have this by tomorrow? This is a first priority. Thanks!
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Ok, got it, when you mentioned following Skeletal implementations, what are the object you want me to look for.
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
It's the classes that follow the pattern from Item 18, Chapter 4.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Got it
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
looks like the class kind of follow the pattern
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
All of them?
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
abstract class FractalCalculator implements Runnable
class AbstractFTPAdapter implements Interface ApplicationAdapter
abstract class KeyList implements IList
abstract class SpellDictionaryASpell implements SpellDictionary
abstract class AbstractWordFinder implements WordFinder
abstract class AbstractWordTokenizer implements WordTokenizer
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
There been used in the other class, which follow the skeletal implementation, as far my understanding.
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
I would highly doubt that FractalCalculator follows this pattern because it is implementing the Runnable interface. Remember, the pattern is to make implementing the interface easier. Runnable only has one method.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Do you agree?
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
agee
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Cool. Please take a closer look at the abstract class to see if it is trying to provide a partial implementation of the interface.
An awesome example of the pattern is java.util.AbstractList.
[--- Commented from Asana.com
#commenter Raffi Khatchadourian
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
I need to download the source code of the library,
[--- Commented from Asana.com
#commenter Md Arefin
---[aa]
from migrate-skeletal-implementation-to-interface-refactoring.
Related Issues (20)
- Add timing to results table
- Parameter names may differ between source and target methods HOT 3
- Assigning a variable to this and calling an inaccessible method should fail HOT 5
- Need LOC of migrated methods HOT 1
- Need number of methods and or things remaining in the source method declaring type HOT 1
- Precondition missing for compile-time type of this HOT 6
- Is precondition present for compile-time type of super? HOT 1
- Add destination interface to failed_preconditions.csv
- UI lock on large projects HOT 1
- Return type matters between source and target methods HOT 1
- Concrete implementer may implement an interface declaring a method with the same signature as the migrated method HOT 5
- Check for type parameter differences between return type and parameter types of source method and target method missing
- extractConstructor(ASTNode) cannot extract default constructors
- extractConstructor(ASTNode) cannot extract default constructors HOT 1
- Precondition check missing for derived sources
- Analyze and manipulate StringTemplate files
- Remove empty abstract skeletal implementer classes HOT 2
- Also migrate constant fields to the destination interface if the source methods are the only one that accesses them
- Also alter any javadoc containing parameter names when changing parameter names in the method declaration
- Allow classes to be deprecated instead of removed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from migrate-skeletal-implementation-to-interface-refactoring.