App icon doesn't display under Wayland about polymc

[binex-dsk]

Where are you talking about?

In settings and about it displays for me properly. However I use sway so I can't see desktop icons.

[baduhai]

Sorry, should have clarified that in docks and some parts of the DE the proper icon doesn't get displayed(only under Wayland, works fine on X11).

Here's what I mean. Example 1. Example 2

[binex-dsk]

Interesting. I can add that potential fix to a branch and you can try building/installing from that.

[baduhai]

I can give a shot, yeah.

[binex-dsk]

OK, I can do this probably between 3 and 5 PM EST.

[d-513]

it works for me on wayland under gnome

[baduhai]

It seems as though this problem is exclusive to the Flatpak package. It works fine on the rpm(OpenSUSE) and Appimage. If you want I can reopen this issue under flathub/org.polymc.PolyMC .

[d-513]

Its probably fine to keep it here, I am using the flatpak too and this isnt happening. Using wayland on fedora 35

[binex-dsk]

Keep it here. I'll work on it soon

[calcastor]

This is an issue I originally noticed with MultiMC on KDE Wayland. I believe it's related to StartupWMClass within the .desktop file and potentially the .desktop file's name though I'm not entirely sure if it's related to both or just one or the other. In my own case I believe I was able to get the window to use the correct icon by fiddling with both the .desktop file's name and the defined StartupWMClass, setting them to org.multimc.MultiMC. This is likely resolvable within the code but if I had to guess it's related to discrepancies with the window class under Wayland and the window class in the .desktop file. I didn't have this issue in KDE X11 or while running MultiMC in XWayland.

I've switched to GNOME and Fedora since I encountered this issue when using MultiMC. With PolyMC installed from Copr, the window "connects" as expected to the .desktop file when I use XWayland. I haven't had the chance to test with launching as Wayland native though.

[binex-dsk]

Freedesktop is total spaghetti that I don't feel like dealing with. Is the WM class configurable in Qt and does it need to be set to org.polymc.PolyMC?

[d-513]

Seems to be broken on MMC too MMC-3500, but maintainer doesnt seem willing to fix that

[d-513]

Though the thing is PolyMC desktop file is correct rDNS, so renaming won't work

[timoreo22]

Your fix seems to only work for qt 5.7, i believe PolyMC currently targets qt 5.6

[binex-dsk]

@baduhai does #95 fix it?

[baduhai]

@baduhai does #95 fix it?

Unfortunately not.

[baduhai]

Was this fix included in 1.0.6? Because neither the flatpak nor the native package for 1.0.6 display the icon properly in Plasma Wayland.

[d-513]

Was this fix included in 1.0.6? Because neither the flatpak nor the native package for 1.0.6 display the icon properly in Plasma Wayland.

No, it wasn't. The fix will be in 1.1.0.