Comments (12)
Overhead was the wrong word here. What I meant is relying on too much logic outside of the repo that is complicated to adapt to our needs here.
from runtimes.
What about a modifying the pull_request_template to inform the users of the requirement?
Could be something like:
<!-- Remember that you can run `/merge` to enable auto-merge in the PR -->
## Checklist
Did you remember to modify the `CHANGELOG.md` file?
- [ ] Yes
The other option is to generate a simple action that can see if the CHANGELOG
file has not been modified and either, comment on the creation of a PR that the file has not been modified, or, fail until the CHANGELOG
file has been modified.
from runtimes.
The other option is to generate a simple action that can see if the
CHANGELOG
file has not been modified and either, comment on the creation of a PR that the file has not been modified, or, fail until theCHANGELOG
file has been modified.
Example using: pr-includes-file-change:
name: Modify Changelog
on:
pull_request_target:
types:
- opened
jobs:
test:
runs-on: ubuntu-latest
env:
GITHUB_TOKEN: ${{ github.token }}
steps:
- name: Get Changed Files
id: changed
uses: foodee/pr-includes-file-change@master
with:
paths: ^CHANGELOG.md
- name: Comment lack of CHANGELOG
if: steps.changed.outputs.matched != 'true'
run: gh pr comment $PR_NUMBER --body "Please modify the CHANGELOG.md file 🗂️"
env:
PR_NUMBER: context.issue.number
- name: Fail
if: steps.changed.outputs.matched != 'true'
run: exit 1
Disclaimer, I haven't tested this action.
from runtimes.
Something in the MR template to skip changelog modification would be good. Then the CI action can check whether the description contains a [x] Does not require a CHANGELOG entry
or so (maybe the question should be more explicit with a Yes
or No
).
from runtimes.
Something in the MR template to skip changelog modification would be good. Then the CI action can check whether the description contains a
[x] Does not require a CHANGELOG entry
or so (maybe the question should be more explicit with aYes
orNo
).
Yes this could work.
from runtimes.
This looks awfully like prdoc...
Changed/Added/Fixed sections kinda look like audiences (and that's configurable with custom schema).
from runtimes.
We may switch to prdoc at some point, but currently I don't want to pull the overhead it brings into this repo. When it is more major etc, we can check it.
from runtimes.
If we don't want to bring overhead, maybe stick to a PR template without any CI for now?
from runtimes.
PR #153 has been created to solve this requirement.
from runtimes.
PR #153 has been merged (e115160). For some reason, this issue has not been closed automatically 🤔
from runtimes.
I assume just because github didn't found the keywords it was searching for.
from runtimes.
It should as the PR does mention that, once it will be merged, it will close the issue:
Maybe they had some internal problem?
Thanks for closing it! ✅
from runtimes.
Related Issues (20)
- [Ambassadors] Reduce `MaxRank` to 3 HOT 1
- `Fail when author pushes new code` should check if the user is not a fellow HOT 1
- Optimistic Project Funding HOT 22
- Implement Unbrick Collective HOT 3
- [CI] Publish unoptimized runtime blobs for debugging HOT 2
- [People] Add new registrar HOT 11
- PeopleKusama, PeoplePolkadot and Encointer don't have price for parent delivery set up HOT 2
- Add fee estimation support for XCMs over P<>K and P<>E bridges
- Treasury Configuration(s) for Multi-Chain Spends HOT 1
- [bridges][AHs] Include ExportMessage fees in XCM message from AH to BH HOT 2
- Update CI for Polkadot People Chain HOT 2
- Remove `chain-spec-generator`
- Check `merge bot` and required pipelines HOT 8
- Add test for coretime Runtime API HOT 1
- Coretime Runtime API: Refactor `burn_at_relay`
- Review bot error: Reviews may only be requested from collaborators HOT 6
- Field `image` on people chain is unusable HOT 5
- Enable StorageWeightReclaim for all the runtime HOT 1
- Consider using `RuntimeGenesisConfig` instead of directly constructing json for the preset genesis patch
- Actually benchmark `pallet_xcm::execute` for all runtimes HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from runtimes.