Comments (3)
@phalt
What are the parameters we're looking for with these tests? I've spent a few hours digging into django/rest framework testing docs and have got some basics going but haven't been done a ton of unit testing and am not really sure to what level we should be digging for validation.
First thought is to take a look at any api resources we have and write a test that will build out entries in all the tables the resource pulls data from, call the api to get the resource and make sure the fields match what would be expected.
Maybe also add a second object and make sure that "list" calls are returning both objects.
Does that sound about right? You think we need anything else? Is calling the api enough validation that objects are being added to the database the way we expect?
from pokeapi.
@zaneadix having good integration tests is a great start. We care about the data given by the API, so we should make sure that is as we expect. Tests that call each resource comparing expected results and actual results is good.
from pokeapi.
Progress made in pull request #62.
from pokeapi.
Related Issues (20)
- Effect and Short Effect are not Reliable HOT 7
- Genus in GraphQL
- GraphQL: Is dual type of X and Y HOT 2
- Replace $effect_chance% with actual value HOT 2
- Error in the data model regarding attributes of species/pokémon HOT 4
- Gen 9 TMs missing HOT 7
- Zygarde PokeDex id is incorrect HOT 2
- Data Model doesnt consider the subcategories of Pokemon HOT 2
- Differences in different APIs handling forms HOT 3
- Provide PMD Portraits and Sprites HOT 4
- Change API to have only one Pokemon endpoint, instead of pokemon_species, pokemon_forms and pokemon HOT 17
- Dual normal-types displaying normal-type as ability HOT 1
- GraphQL api is down HOT 3
- Add pokemon cries to GraphqQL response HOT 1
- move effect prose 1 and 104 are the same HOT 3
- Why isnt csv a submodule just like sprites and cries? HOT 2
- Pokemons rename in species request HOT 2
- Problem with item flag countable HOT 4
- Link up --physical and --special Z moves to complete their data HOT 1
- Eevee's gender differences HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pokeapi.