Coder Social home page Coder Social logo

Comments (4)

PoisonAlien avatar PoisonAlien commented on July 17, 2024

Hi,

Thanks for reporting this !
This was a mistake from my side, should have been more careful. You were right about adding hugo_symbol to barcodes. I have fixed it. Thanks again.

P.S: that after subsetting in the above example you may not be be able to draw heat maps or rainfall plots since you're left with only one sample.

from maftools.

sribi avatar sribi commented on July 17, 2024

Hi,
Thanks a lot for fixing this so promptly! subsetMaf() and oncoplot() now work as expected. However, I am still having issues with 'rainfallPlot()':

#import
> var.annovar.maf <- annovarToMaf(annovar = var.annovar, Center = 'CSI-NUS', refBuild = 'hg19', tsbCol = 'Tumor_Sample_Barcode', table = 'ensGene', header = TRUE, MAFobj=TRUE)

#plot
> rainfallPlot(maf=var.annovar.maf, detectChangePoints = TRUE, fontSize = 12, pointSize = 0.6)
Error in seg.spl[[1]] : subscript out of bounds
In addition: Warning message:
In is.factor(x) : NAs introduced by coercion

#check if more than one sample 
> getSampleSummary(var.annovar.maf)
   Tumor_Sample_Barcode Frame_Shift_Del Frame_Shift_Ins Missense_Mutation total
1:               fake_4               1               0                 1     2
2:               fake_5               0               1                 1     2
3:               fake_7               0               1                 1     2
4:               fake_1               0               0                 1     1
5:               fake_2               0               0                 1     1
6:               fake_3               0               0                 1     1
7:               fake_6               0               0                 1     1

I was assuming the issue might be due to the low number of mutations in the test dataset, but I'm running into the same issue with my own, larger dataset with plenty of mutations...

Thanks again,
sribi

from maftools.

PoisonAlien avatar PoisonAlien commented on July 17, 2024

Hi,
This was an issue with empty chromosomes. i.e, chromosomes with no variants resulted in error. I have fixed it. I would really appreciate if you could try installing it again and let me know if it works.

Target level branch, since I haven't merged it with master yet.

devtools::install_github(repo = "PoisonAlien/maftools", ref = 'devel')

Thanks again. This was helpful.

from maftools.

sribi avatar sribi commented on July 17, 2024

Hi,

The bug in rainfallPlot() , as described above, seems to be fixed in your latest push to devel!

Thanks for fixing it so quickly.

from maftools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.